Merge pull request #67030 from CyrusNajmabadi/disablePreviewDiagnostics

Disable diagnostics in the preview window

Author: mavasani

src/EditorFeatures/Core/Diagnostics/AbstractPushOrPullDiagnosticsTaggerProvider.SingleDiagnosticKindPullTaggerProvider.cs

@@ -95,6 +95,9 @@ private async Task ProduceTagsAsync(
             if (document == null)
                 return;
 
+            if (document.Project.Solution.Workspace.Kind == WorkspaceKind.Preview)
+                return;
+
             var snapshot = documentSpanToTag.SnapshotSpan.Snapshot;
 
             var project = document.Project;

src/EditorFeatures/Test/Preview/PreviewWorkspaceTests.cs

@@ -157,7 +157,7 @@ public async Task TestPreviewDiagnosticTagger()
         }
 
         [WpfFact]
-        public async Task TestPreviewDiagnosticTaggerInPreviewPane()
+        public async Task TestPreviewDiagnosticTaggerInPreviewPaneDoesNotWork()
         {
             // TODO: WPF required due to https://github.com/dotnet/roslyn/issues/46153
             using var workspace = TestWorkspace.CreateCSharp("class { }", composition: EditorTestCompositions.EditorFeaturesWpf);
@@ -173,7 +173,7 @@ public async Task TestPreviewDiagnosticTaggerInPreviewPane()
             var newDocument = oldDocument.WithText(oldText.WithChanges(new TextChange(new TextSpan(0, oldText.Length), "class C { }")));
 
             // create a diff view
-            WpfTestRunner.RequireWpfFact($"{nameof(TestPreviewDiagnosticTaggerInPreviewPane)} creates a {nameof(DifferenceViewerPreview)}");
+            WpfTestRunner.RequireWpfFact($"{nameof(TestPreviewDiagnosticTaggerInPreviewPaneDoesNotWork)} creates a {nameof(DifferenceViewerPreview)}");
 
             var previewFactoryService = (PreviewFactoryService)workspace.ExportProvider.GetExportedValue<IPreviewFactoryService>();
             using var diffView = await previewFactoryService.CreateChangedDocumentPreviewViewAsync(oldDocument, newDocument, CancellationToken.None);
@@ -211,7 +211,7 @@ public async Task TestPreviewDiagnosticTaggerInPreviewPane()
             // check left buffer
             var leftSnapshot = leftBuffer.CurrentSnapshot;
             var leftSpans = leftTagger.GetTags(leftSnapshot.GetSnapshotSpanCollection()).ToList();
-            Assert.Equal(1, leftSpans.Count);
+            Assert.Equal(0, leftSpans.Count);
 
             // check right buffer
             var rightSnapshot = rightBuffer.CurrentSnapshot;