Skip to content

Commit 8ab2924

Browse files
authored
Inline Hints - Don't allow double click and insert params arguments (#68434)
* don't insert params args * fix tests
1 parent 826e177 commit 8ab2924

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

src/EditorFeatures/Test2/InlineHints/CSharpInlineParameterNameHintsTests.vb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,7 @@ class A
458458

459459
public void Main(string[] args)
460460
{
461-
UseParams(list: 1, 2, 3, 4, 5, 6);
461+
UseParams(1, 2, 3, 4, 5, 6);
462462
}
463463
}
464464
</Document>

src/EditorFeatures/Test2/InlineHints/VisualBasicInlineParameterNameHintsTests.vb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.InlineHints
466466
End Sub
467467

468468
Public Sub Main()
469-
UseParams(args:=1, 2, 3, 4, 5)
469+
UseParams(1, 2, 3, 4, 5)
470470
End Sub
471471
End Class
472472
</Document>

src/Features/Core/Portable/InlineHints/AbstractInlineParameterNameHintsService.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,17 @@ void AddHintsIfAppropriate(SyntaxNode node)
102102
{
103103
var inlineHintText = GetReplacementText(parameter.Name);
104104
var textSpan = new TextSpan(position, 0);
105+
106+
TextChange? replacementTextChange = null;
107+
if (!parameter.IsParams)
108+
{
109+
replacementTextChange = new TextChange(textSpan, inlineHintText);
110+
}
111+
105112
result.Add(new InlineHint(
106113
textSpan,
107114
ImmutableArray.Create(new TaggedText(TextTags.Text, parameter.Name + ": ")),
108-
new TextChange(textSpan, inlineHintText),
115+
replacementTextChange,
109116
ranking: InlineHintsConstants.ParameterRanking,
110117
InlineHintHelpers.GetDescriptionFunction(position, parameter.GetSymbolKey(cancellationToken: cancellationToken), displayOptions)));
111118
}

0 commit comments

Comments
 (0)