Skip to content

Conversation

@carlossanlop
Copy link

@carlossanlop carlossanlop commented Dec 7, 2023

Now that we shipped 8.0.1xx, we need to revert localization back to point to main. I already opened the internal issue for the loc team to track this request.

Here is the old PR that temporarily moved main to 8.0.1xx: https://github.com/dotnet/roslyn-analyzers/pull/6890/files

Question: This change was also backported to the 8.0.1xx branch. Do I also need to revert the change in that branch, or can that one stay as is?

Edit: Answer: I need to backport it to release/8.0.2xx. I don't think I should backport it to 8.0.1xx, that branch won't be active again.

@codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #7072 (d839075) into main (94955fd) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7072      +/-   ##
==========================================
- Coverage   96.43%   96.43%   -0.01%     
==========================================
  Files        1412     1412              
  Lines      336968   336968              
  Branches    11143    11143              
==========================================
- Hits       324946   324941       -5     
- Misses       9218     9224       +6     
+ Partials     2804     2803       -1     

@carlossanlop
Copy link
Author

/backport to release/8.0.2xx

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

@carlossanlop carlossanlop merged commit 36d92ae into dotnet:main Dec 8, 2023
@carlossanlop carlossanlop deleted the LocMain branch December 8, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants