Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add textDocument/inlayHints support #9904

Merged
merged 14 commits into from
Feb 6, 2024
Merged

Add textDocument/inlayHints support #9904

merged 14 commits into from
Feb 6, 2024

Conversation

davidwengier
Copy link
Contributor

@davidwengier davidwengier commented Feb 6, 2024 •
edited
Loading

Adds inlay hint support for Razor in VS and VS Code, cohosting and regular.

Goes with dotnet/vscode-csharp#6857 for the VS Code side.

@davidwengier davidwengier requested a review from a team as a code owner February 6, 2024 02:05
@davidwengier davidwengier mentioned this pull request Feb 6, 2024
Merged
alexgav
alexgav approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DoctorKrolic
Copy link
Contributor

Fixes: #7910

@davidwengier
Copy link
Contributor Author

davidwengier commented Feb 6, 2024 •
edited
Loading

Oh cool, thanks! Worth noting that tooltip and double click support is not in VS, but we don't have to do any new work when they add those features. Both work in VS Code.

@davidwengier davidwengier merged commit 4ab2609 into dotnet:main Feb 6, 2024
12 checks passed
@davidwengier davidwengier deleted the InlayHints branch February 6, 2024 20:43
@ghost ghost added this to the Next milestone Feb 6, 2024
@jjonescz jjonescz modified the milestones: Next, 17.10 P2 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgav alexgav alexgav approved these changes

@maryamariyan maryamariyan maryamariyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.10 P2
Development

Successfully merging this pull request may close these issues.
5 participants
@davidwengier @DoctorKrolic @alexgav @maryamariyan @jjonescz