Add option for element completion commit characters #9379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
approved these changes
Oct 9, 2023
| } | ||
| } | ||
|
|
||
| foreach (var item in completionList.Items) |
There was a problem hiding this comment.
If 'itemCommitChars' is null can we just early return and do nothing?
There was a problem hiding this comment.
No, because each item could specify its own commit characters, so we still have to go through them all and update that. If itemCommitChars is null it just means the server didn't specify a default set.
DustinCampbell
approved these changes
Oct 9, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the "we did not find firm opinions" part of #8295 by introducing an option to allow users to control how they want completion for html elements, tag helper elements and components to behave.
Corresponding VS Code PR: dotnet/vscode-csharp#6506