Skip to content

Avoid using Ancestors().FirstOrDefault() #9053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2023
Merged

Avoid using Ancestors().FirstOrDefault() #9053

merged 1 commit into from
Jul 28, 2023

Conversation

@333fred
Copy link
Member

@333fred 333fred commented Jul 28, 2023

Small refactoring I noticed to reduce a few unnecessary closure allocations

@333fred
Avoid using Ancestors().FirstOrDefault()
380a940 
Small refactoring I noticed to reduce a few unnecessary closure allocations
@333fred 333fred requested a review from a team as a code owner July 28, 2023 21:24
@333fred 333fred mentioned this pull request Jul 28, 2023
Merged
@333fred 333fred enabled auto-merge (squash) July 28, 2023 21:35
@333fred 333fred merged commit e2061f3 into dotnet:main Jul 28, 2023
@ghost ghost added this to the Next milestone Jul 28, 2023
@333fred 333fred deleted the firstancestororself branch July 28, 2023 23:02
@allisonchou allisonchou mentioned this pull request Jul 31, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier approved these changes

+1 more reviewer

@ryzngard ryzngard ryzngard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

17.8

Development

Successfully merging this pull request may close these issues.

4 participants

@333fred @ryzngard @davidwengier @Cosifne