Don't try and de-dup tag helper descriptors #8267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chsienki
force-pushed
the
fix_taghelper_lookup
branch
from
bc86c69 to
160d4f5
Compare
davidwengier
approved these changes
Feb 14, 2023
Member
Author
|
@dotnet/razor-compiler for review please |
jjonescz
approved these changes
Feb 14, 2023
jjonescz
approved these changes
Feb 15, 2023
333fred
approved these changes
Feb 15, 2023
Member
|
I have restarted a build step to get it green (network failure I think). It's all green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #8135
Unfortunately, it isn't valid to short circuit in all cases. It's possible for a descriptor to have multiple registration keys. We also can't just add it when we create the hash set, because it could be created by a different provider.
We could probably track which sets a descriptor has been added to, so as to not try and add it multiple times, but I'm not convinced it would be all that much faster (we can benchmark this in another PR if we're interested).