Don't kill all code actions when a delegated server misbehaves #8214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Feb 3, 2023
| } | ||
| catch (RemoteInvocationException e) | ||
| { | ||
| logger.LogException(e, "Error getting code actions from delegate language server for {languageKind}", languageKind); |
Member
Author
There was a problem hiding this comment.
This means we'll get a prism bug if enough of these happens, which will be good to highlight for partner teams, but won't prevent us from showing Razor code actions either
DustinCampbell
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #8207
That PR fixes the issue, this PR makes us resiliant to downstream servers throwing exceptions getting code actions in general (and adds ConfigureAwait calls because there were a few missing)