Improve document handling in VS Code and cohosting #11825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
approved these changes
May 7, 2025
Contributor
ryzngard
left a comment
ryzngard
left a comment
There was a problem hiding this comment.
Overall LGTM. One small qualm with the ToString() usage but not blocking (and potentially just uninformed :) )
...rc/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Cohost/HtmlRequestInvoker.cs
Outdated
Show resolved
Hide resolved
This was referenced May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11759
Goes with dotnet/vscode-csharp#8259
This adds a notification for VS Code to tell us that a Razor file has closed, so we can clear our cache, and also adds checksum matching to Html requests in VS and VS Code so we can ensure we're not out-of-sync.