Skip to content

Unskip diagnostic integration tests #11560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidwengier merged 2 commits into from
Feb 26, 2025
Merged

Unskip diagnostic integration tests #11560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cce965
Unskip diagnostics tests
davidwengier Feb 26, 2025
59c0a2d
Fix typo and whitepsace
davidwengier Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions ...t/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/RemoteDebugInfoServiceTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

namespace Microsoft.VisualStudio.Razor.LanguageClient.Cohost;

public class RemoveDebugInfoServiceTest(ITestOutputHelper testOutputHelper) : CohostEndpointTestBase(testOutputHelper)
public class RemoteDebugInfoServiceTest(ITestOutputHelper testOutputHelper) : CohostEndpointTestBase(testOutputHelper)
{
[Fact]
public async Task ResolveProximityExpressionsAsync_Html()
Expand Down Expand Up @@ -182,11 +182,11 @@ private async Task VerifyProximityExpressionsAsync(TestCode input, string[] extr
var span = inputText.GetLinePosition(input.Position);

var result = await RemoteServiceInvoker
.TryInvokeAsync<IRemoteDebugInfoService, string[]?>(
document.Project.Solution,
(service, solutionInfo, cancellationToken) =>
service.ResolveProximityExpressionsAsync(solutionInfo, document.Id, span, cancellationToken),
DisposalToken);
.TryInvokeAsync<IRemoteDebugInfoService, string[]?>(
document.Project.Solution,
(service, solutionInfo, cancellationToken) =>
service.ResolveProximityExpressionsAsync(solutionInfo, document.Id, span, cancellationToken),
DisposalToken);

if (!input.HasSpans)
{
Expand All @@ -208,11 +208,11 @@ private async Task VerifyBreakpointRangeAsync(TestCode input)
var span = inputText.GetLinePosition(input.Position);

var result = await RemoteServiceInvoker
.TryInvokeAsync<IRemoteDebugInfoService, LinePositionSpan?>(
document.Project.Solution,
(service, solutionInfo, cancellationToken) =>
service.ResolveBreakpointRangeAsync(solutionInfo, document.Id, span, cancellationToken),
DisposalToken);
.TryInvokeAsync<IRemoteDebugInfoService, LinePositionSpan?>(
document.Project.Solution,
(service, solutionInfo, cancellationToken) =>
service.ResolveBreakpointRangeAsync(solutionInfo, document.Id, span, cancellationToken),
DisposalToken);

if (result is not { } breakpoint)
{
Expand Down
10 changes: 5 additions & 5 deletions src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/DiagnosticTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Microsoft.VisualStudio.Razor.IntegrationTests;

public class DiagnosticTests(ITestOutputHelper testOutputHelper) : AbstractRazorEditorTest(testOutputHelper)
{
[ConditionalSkipIdeFact(Issue = "https://github.com/dotnet/razor/issues/8150")]
[IdeFact]
public async Task Diagnostics_ShowErrors_Razor()
{
// Arrange
Expand Down Expand Up @@ -50,7 +50,7 @@ public void Function(){
});
}

[ConditionalSkipIdeFact(Issue = "https://github.com/dotnet/razor/issues/8150")]
[IdeFact]
public async Task Diagnostics_ShowErrors_Html()
{
// Arrange
Expand Down Expand Up @@ -82,7 +82,7 @@ await TestServices.Editor.SetTextAsync(@"
});
}

[ConditionalSkipIdeFact(Issue = "https://github.com/dotnet/razor/issues/8150")]
[IdeFact]
public async Task Diagnostics_ShowErrors_CSharp()
{
// Arrange
Expand Down Expand Up @@ -114,7 +114,7 @@ await TestServices.Editor.SetTextAsync(@"
});
}

[ConditionalSkipIdeFact(Issue = "https://github.com/dotnet/razor/issues/8150")]
[IdeFact]
public async Task Diagnostics_ShowErrors_CSharp_NoDocType()
{
// Why this test, when we have the above test, and they seem so similar, and we also have Diagnostics_ShowErrors_CSharpAndHtml you ask? Well I'll tell you!
Expand Down Expand Up @@ -154,7 +154,7 @@ await TestServices.Editor.SetTextAsync(@"
});
}

[ConditionalSkipIdeFact(Issue = "https://github.com/dotnet/razor/issues/8150")]
[IdeFact]
public async Task Diagnostics_ShowErrors_CSharpAndHtml()
{
// Arrange
Expand Down