From 2cce965426f62768067ec3d055dc79393b51f610 Mon Sep 17 00:00:00 2001 From: David Wengier Date: Wed, 26 Feb 2025 15:07:48 +1100 Subject: [PATCH 1/2] Unskip diagnostics tests --- .../DiagnosticTests.cs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/DiagnosticTests.cs b/src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/DiagnosticTests.cs index 76c63f0a8e2..b6f7c8bc44f 100644 --- a/src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/DiagnosticTests.cs +++ b/src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/DiagnosticTests.cs @@ -10,7 +10,7 @@ namespace Microsoft.VisualStudio.Razor.IntegrationTests; public class DiagnosticTests(ITestOutputHelper testOutputHelper) : AbstractRazorEditorTest(testOutputHelper) { - [ConditionalSkipIdeFact(Issue = "https://github.com/dotnet/razor/issues/8150")] + [IdeFact] public async Task Diagnostics_ShowErrors_Razor() { // Arrange @@ -50,7 +50,7 @@ public void Function(){ }); } - [ConditionalSkipIdeFact(Issue = "https://github.com/dotnet/razor/issues/8150")] + [IdeFact] public async Task Diagnostics_ShowErrors_Html() { // Arrange @@ -82,7 +82,7 @@ await TestServices.Editor.SetTextAsync(@" }); } - [ConditionalSkipIdeFact(Issue = "https://github.com/dotnet/razor/issues/8150")] + [IdeFact] public async Task Diagnostics_ShowErrors_CSharp() { // Arrange @@ -114,7 +114,7 @@ await TestServices.Editor.SetTextAsync(@" }); } - [ConditionalSkipIdeFact(Issue = "https://github.com/dotnet/razor/issues/8150")] + [IdeFact] public async Task Diagnostics_ShowErrors_CSharp_NoDocType() { // Why this test, when we have the above test, and they seem so similar, and we also have Diagnostics_ShowErrors_CSharpAndHtml you ask? Well I'll tell you! @@ -154,7 +154,7 @@ await TestServices.Editor.SetTextAsync(@" }); } - [ConditionalSkipIdeFact(Issue = "https://github.com/dotnet/razor/issues/8150")] + [IdeFact] public async Task Diagnostics_ShowErrors_CSharpAndHtml() { // Arrange From 59c0a2d4d44e8a2a2c46f4af1bcd650e15faecf0 Mon Sep 17 00:00:00 2001 From: David Wengier Date: Wed, 26 Feb 2025 15:07:55 +1100 Subject: [PATCH 2/2] Fix typo and whitepsace --- .../Cohost/RemoteDebugInfoServiceTest.cs | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/RemoteDebugInfoServiceTest.cs b/src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/RemoteDebugInfoServiceTest.cs index 103bf1729cf..4358c600e1d 100644 --- a/src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/RemoteDebugInfoServiceTest.cs +++ b/src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/RemoteDebugInfoServiceTest.cs @@ -14,7 +14,7 @@ namespace Microsoft.VisualStudio.Razor.LanguageClient.Cohost; -public class RemoveDebugInfoServiceTest(ITestOutputHelper testOutputHelper) : CohostEndpointTestBase(testOutputHelper) +public class RemoteDebugInfoServiceTest(ITestOutputHelper testOutputHelper) : CohostEndpointTestBase(testOutputHelper) { [Fact] public async Task ResolveProximityExpressionsAsync_Html() @@ -182,11 +182,11 @@ private async Task VerifyProximityExpressionsAsync(TestCode input, string[] extr var span = inputText.GetLinePosition(input.Position); var result = await RemoteServiceInvoker - .TryInvokeAsync( - document.Project.Solution, - (service, solutionInfo, cancellationToken) => - service.ResolveProximityExpressionsAsync(solutionInfo, document.Id, span, cancellationToken), - DisposalToken); + .TryInvokeAsync( + document.Project.Solution, + (service, solutionInfo, cancellationToken) => + service.ResolveProximityExpressionsAsync(solutionInfo, document.Id, span, cancellationToken), + DisposalToken); if (!input.HasSpans) { @@ -208,11 +208,11 @@ private async Task VerifyBreakpointRangeAsync(TestCode input) var span = inputText.GetLinePosition(input.Position); var result = await RemoteServiceInvoker - .TryInvokeAsync( - document.Project.Solution, - (service, solutionInfo, cancellationToken) => - service.ResolveBreakpointRangeAsync(solutionInfo, document.Id, span, cancellationToken), - DisposalToken); + .TryInvokeAsync( + document.Project.Solution, + (service, solutionInfo, cancellationToken) => + service.ResolveBreakpointRangeAsync(solutionInfo, document.Id, span, cancellationToken), + DisposalToken); if (result is not { } breakpoint) {