[Cohost] Remove unnecessary indirection in semantic tokens #10369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, $"Error calling remote"); |
Member
There was a problem hiding this comment.
Should this also go to telemetry?
Member
Author
There was a problem hiding this comment.
Good point. We do get whatever Roslyn has for free (ie, we get yellow bars for razor services etc.), but can't hurt logging our own too. Will leave as a follow up though, am planning on simplifiying the IRemoteClientProvider API tonight in the car, as everything current copies around the same boilerplate, and its annoying.
DustinCampbell
approved these changes
May 15, 2024
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being the first endpoint created, semantic tokens had a little bit of over design. I did not YAGNI 😁