Revert "Improve build reliability by removing conversion to Windows PDB (#11548)"

phil-allen-msft · phil-allen-msft · commit 1c9aa365517e · 2025-02-27T13:46:39.000-08:00
This reverts commit d51413c.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -28,9 +28,6 @@
     <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
     <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
 
-    <!-- VS does not require Windows PDBs to be published anymore. -->
-    <PublishWindowsPdb>false</PublishWindowsPdb>
-
     <SharedSourceRoot>$(MSBuildThisFileDirectory)src\Shared\</SharedSourceRoot>
     <SharedFilesRoot>$(SharedSourceRoot)files\</SharedFilesRoot>
 
diff --git a/src/Analyzers/Directory.Build.props b/src/Analyzers/Directory.Build.props
@@ -8,6 +8,9 @@
     <IncludeSymbols>true</IncludeSymbols>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
 
+    <!-- In theory we want to have this property set, but our pipeline doesn't set the access tokens yet -->
+    <PublishWindowsPdb Condition="'$(DotNetSymbolServerTokenMsdl)'!='' and '$(DotNetSymbolServerTokenSymWeb)'!=''">true</PublishWindowsPdb>
+
     <RollForward Condition="'$(IsTestProject)' == 'true'">LatestMajor</RollForward>
   </PropertyGroup>
 
diff --git a/src/Razor/src/Directory.Build.props b/src/Razor/src/Directory.Build.props
@@ -8,6 +8,8 @@
     <IncludeSymbols>true</IncludeSymbols>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
 
+    <!-- In theory we want to have this property set, but our pipeline doesn't set the access tokens yet -->
+    <PublishWindowsPdb Condition="'$(DotNetSymbolServerTokenMsdl)'!='' and '$(DotNetSymbolServerTokenSymWeb)'!=''">true</PublishWindowsPdb>
   </PropertyGroup>
 
 </Project>
diff --git a/src/Shared/Directory.Build.props b/src/Shared/Directory.Build.props
@@ -8,6 +8,9 @@
     <IncludeSymbols>true</IncludeSymbols>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
 
+    <!-- In theory we want to have this property set, but our pipeline doesn't set the access tokens yet -->
+    <PublishWindowsPdb Condition="'$(DotNetSymbolServerTokenMsdl)'!='' and '$(DotNetSymbolServerTokenSymWeb)'!=''">true</PublishWindowsPdb>
+
     <RollForward Condition="'$(IsTestProject)' == 'true'">LatestMajor</RollForward>
   </PropertyGroup>
 
