Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Linux/x64: 8 Regressions on 10/3/2023 8:04:03 PM #23013

Open
performanceautofiler bot opened this issue Oct 12, 2023 · 1 comment
Open

[Perf] Linux/x64: 8 Regressions on 10/3/2023 8:04:03 PM #23013

performanceautofiler bot opened this issue Oct 12, 2023 · 1 comment
Assignees
@BrzVlad
Labels
arch-wasm arch-x64 branch-refs/heads/main kind-micro os-linux perf-regression untriaged

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Oct 12, 2023 •
edited
Loading

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 7abea9ea6ac3cde23fe1a890338e22a5a58a51b6
Compare 213833ea99b79a4b494b2935e1ccb10b93cd4cbc
Diff Diff
Configs CompilationMode:wasm, RunKind:micro

Regressions in System.Memory.Span<Int32>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
48.80 ns 62.21 ns 1.27 0.51 False
324.74 ns 834.60 ns 2.57 0.18 True
62.66 ns 116.96 ns 1.87 0.41 True

graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Memory.Span&lt;Int32&gt;*'

Payloads

Baseline
Compare

System.Memory.Span<Int32>.LastIndexOfValue(Size: 4)

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 62.21245951490272 > 47.056187355942384.
IsChangePoint: Marked as a change because one of 10/3/2023 2:46:17 PM, 10/11/2023 8:44:35 PM falls between 10/3/2023 8:20:31 AM and 10/11/2023 8:44:35 PM.
IsRegressionStdDev: Marked as regression because -11.517203943512378 (T) = (0 -67.06888049787791) / Math.Sqrt((15.685222885597295 / (16)) + (80.9144934251401 / (32))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (16) + (32) - 2, .025) and -0.4742106596022531 = (45.49477380388317 - 67.06888049787791) / 45.49477380388317 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

System.Memory.Span<Int32>.LastIndexOfValue(Size: 512)

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 834.5961217595146 > 340.60399418386396.
IsChangePoint: Marked as a change because one of 10/3/2023 2:46:17 PM, 10/11/2023 8:44:35 PM falls between 10/3/2023 8:20:31 AM and 10/11/2023 8:44:35 PM.
IsRegressionStdDev: Marked as regression because -383.18156729121677 (T) = (0 -834.7963058554359) / Math.Sqrt((21.039955655014598 / (16)) + (14.343417527725343 / (32))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (16) + (32) - 2, .025) and -1.5608631260369852 = (325.9823992027676 - 834.7963058554359) / 325.9823992027676 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

System.Memory.Span<Int32>.LastIndexOfValue(Size: 33)

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 116.96123960580458 > 65.96097703408634.
IsChangePoint: Marked as a change because one of 10/3/2023 2:46:17 PM, 10/11/2023 8:44:35 PM falls between 10/3/2023 8:20:31 AM and 10/11/2023 8:44:35 PM.
IsRegressionStdDev: Marked as regression because -37.70223913220826 (T) = (0 -117.46471030834309) / Math.Sqrt((17.826307038038593 / (16)) + (26.90703525793048 / (32))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (16) + (32) - 2, .025) and -0.8141522490944836 = (64.74909168564791 - 117.46471030834309) / 64.74909168564791 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 7abea9ea6ac3cde23fe1a890338e22a5a58a51b6
Compare 213833ea99b79a4b494b2935e1ccb10b93cd4cbc
Diff Diff
Configs CompilationMode:wasm, RunKind:micro

Regressions in System.Memory.Span<Char>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
171.35 ns 755.45 ns 4.41 0.24 True
53.44 ns 146.88 ns 2.75 0.46 True

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Memory.Span&lt;Char&gt;*'

Payloads

Baseline
Compare

System.Memory.Span<Char>.LastIndexOfValue(Size: 512)

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 755.4493166241348 > 180.9260219075908.
IsChangePoint: Marked as a change because one of 10/3/2023 2:46:17 PM, 10/11/2023 8:44:35 PM falls between 10/3/2023 8:20:31 AM and 10/11/2023 8:44:35 PM.
IsRegressionStdDev: Marked as regression because -407.41023938593173 (T) = (0 -750.892251767135) / Math.Sqrt((13.960469529005765 / (16)) + (36.23773677660978 / (32))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (16) + (32) - 2, .025) and -3.315141337374475 = (174.0133620337014 - 750.892251767135) / 174.0133620337014 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

System.Memory.Span<Char>.LastIndexOfValue(Size: 33)

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 146.87737439915173 > 59.902611614972415.
IsChangePoint: Marked as a change because one of 10/3/2023 2:46:17 PM, 10/11/2023 8:44:35 PM falls between 10/3/2023 8:20:31 AM and 10/11/2023 8:44:35 PM.
IsRegressionStdDev: Marked as regression because -37.35632003877844 (T) = (0 -123.73763311274897) / Math.Sqrt((7.908648475854435 / (16)) + (87.08843414096359 / (32))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (16) + (32) - 2, .025) and -1.1804832540942571 = (56.747802525155315 - 123.73763311274897) / 56.747802525155315 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 7abea9ea6ac3cde23fe1a890338e22a5a58a51b6
Compare 213833ea99b79a4b494b2935e1ccb10b93cd4cbc
Diff Diff
Configs CompilationMode:wasm, RunKind:micro

Regressions in Microsoft.Extensions.Primitives.StringSegmentBenchmark

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
54.77 ns 76.00 ns 1.39 0.57 True

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'Microsoft.Extensions.Primitives.StringSegmentBenchmark*'

Payloads

Baseline
Compare

Microsoft.Extensions.Primitives.StringSegmentBenchmark.LastIndexOf

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 76.00273375991067 > 53.0270642362473.
IsChangePoint: Marked as a change because one of 10/3/2023 2:46:17 PM, 10/11/2023 8:44:35 PM falls between 10/3/2023 8:20:31 AM and 10/11/2023 8:44:35 PM.
IsRegressionStdDev: Marked as regression because -31.00260259086538 (T) = (0 -78.06162000890457) / Math.Sqrt((6.219118713185449 / (16)) + (10.832915994575718 / (32))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (16) + (32) - 2, .025) and -0.5121361902592106 = (51.623405690411545 - 78.06162000890457) / 51.623405690411545 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 7abea9ea6ac3cde23fe1a890338e22a5a58a51b6
Compare 213833ea99b79a4b494b2935e1ccb10b93cd4cbc
Diff Diff
Configs CompilationMode:wasm, RunKind:micro

Regressions in System.Collections.ContainsTrue<Int32>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
233.46 μs 477.82 μs 2.05 0.28 True

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.ContainsTrue&lt;Int32&gt;*'

Payloads

Baseline
Compare

System.Collections.ContainsTrue<Int32>.Stack(Size: 512)

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 477.81588271103897 > 222.47363675999634.
IsChangePoint: Marked as a change because one of 10/3/2023 2:46:17 PM, 10/11/2023 8:44:35 PM falls between 10/3/2023 8:20:31 AM and 10/11/2023 8:44:35 PM.
IsRegressionStdDev: Marked as regression because -35.128449078094015 (T) = (0 -492998.91439779353) / Math.Sqrt((112911988.69375414 / (16)) + (1760002391.1540992 / (32))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (16) + (32) - 2, .025) and -1.27955350540565 = (216269.94638586632 - 492998.91439779353) / 216269.94638586632 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 7abea9ea6ac3cde23fe1a890338e22a5a58a51b6
Compare 213833ea99b79a4b494b2935e1ccb10b93cd4cbc
Diff Diff
Configs CompilationMode:wasm, RunKind:micro

Regressions in System.Collections.ContainsFalse<Int32>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
343.85 μs 871.43 μs 2.53 0.19 True

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.ContainsFalse&lt;Int32&gt;*'

Payloads

Baseline
Compare

System.Collections.ContainsFalse<Int32>.Stack(Size: 512)

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 871.4300208333335 > 359.62652188179356.
IsChangePoint: Marked as a change because one of 10/3/2023 2:46:17 PM, 10/11/2023 8:44:35 PM falls between 10/3/2023 8:20:31 AM and 10/11/2023 8:44:35 PM.
IsRegressionStdDev: Marked as regression because -23.41781998345187 (T) = (0 -870645.908893578) / Math.Sqrt((7060978865.391527 / (16)) + (11370279.890512314 / (32))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (16) + (32) - 2, .025) and -1.3002521106064553 = (378500.210859076 - 870645.908893578) / 378500.210859076 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot mentioned this issue Oct 12, 2023
Closed
@radekdoulik
Copy link
Member

looks like dotnet/runtime#90764

it is already handled here #22914

the range is dotnet/runtime@88f2547...d2e24fa

This was referenced Oct 25, 2023
Open
Closed
@DrewScoggins DrewScoggins mentioned this issue Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrzVlad BrzVlad

Labels
arch-wasm arch-x64 branch-refs/heads/main kind-micro os-linux perf-regression untriaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@radekdoulik @BrzVlad