Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 2 Improvements on 5/31/2023 7:24:26 AM #18533

Open
performanceautofiler bot opened this issue Jun 6, 2023 · 3 comments
Open

[Perf] Linux/x64: 2 Improvements on 5/31/2023 7:24:26 AM #18533

performanceautofiler bot opened this issue Jun 6, 2023 · 3 comments

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Jun 6, 2023

Run Information

Name Value
Architecture x64
OS ubuntu 18.04
Queue TigerUbuntu
Baseline bf7fb2ecbf69deb6a73bb8bbca1e56e7beec8d8a
Compare 1af3c9eb5d97b61f75a387e43d9c9d6a20dd2e23
Diff Diff
Configs CompilationMode:wasm, RunKind:micro

Improvements in StoreBlock.AnyLocation

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CopyBlock128 - Duration of single invocation 8.41 ns 0.00 ns 0.00 0.16 False
CopyBlock64 - Duration of single invocation 8.19 ns 0.00 ns 0.00 0.12 False

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'StoreBlock.AnyLocation*'

Payloads

Baseline
Compare

Histogram

StoreBlock.AnyLocation.CopyBlock128


Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 0 < 7.987085521246584.
IsChangePoint: Marked as a change because one of 3/6/2023 4:48:38 PM, 5/30/2023 10:12:23 PM, 6/5/2023 10:09:45 PM falls between 5/27/2023 6:38:16 PM and 6/5/2023 10:09:45 PM.
IsImprovementStdDev: Marked as improvement because 98.44314589443968 (T) = (0 -0) / Math.Sqrt((2.6860258081846933 / (299)) + (0 / (20))) is greater than 1.9674756580274855 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (20) - 2, .975) and 1 = (9.33050135327891 - 0) / 9.33050135327891 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

StoreBlock.AnyLocation.CopyBlock64


Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 0 < 7.796659245041104.
IsChangePoint: Marked as a change because one of 3/6/2023 4:48:38 PM, 5/30/2023 10:12:23 PM, 6/5/2023 10:09:45 PM falls between 5/27/2023 6:38:16 PM and 6/5/2023 10:09:45 PM.
IsImprovementStdDev: Marked as improvement because 137.15978845252616 (T) = (0 -0) / Math.Sqrt((1.0893390305710218 / (299)) + (0 / (20))) is greater than 1.9674756580274855 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (20) - 2, .975) and 1 = (8.278902056447826 - 0) / 8.278902056447826 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@radekdoulik
Copy link
Member

@kg could that be dotnet/runtime#86403 or is the measurement broken? :-)

@kg
Copy link
Member

kg commented Jun 8, 2023

These two benchmarks appear to have started crashing. I'm not sure why that reports as a 0 and is an "improvement" :)

@kg
Copy link
Member

kg commented Jun 8, 2023

Should be fixed by dotnet/runtime#87246. We should look into whether we can detect crashed wasm benchmarks and surface them as something other than "improvements" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants