diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 45701df1429..6f5c6db1ca1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -346,15 +346,14 @@ jobs: matrix: provider: ["Consul"] framework: [net8.0] - services: - consul: - image: hashicorp/consul - ports: - - 8500:8500 - - 8600:8600/tcp - - 8600:8600/udp steps: - uses: actions/checkout@v4 + - name: Start Consul + run: | + docker run -d --name consul -p 8500:8500 -p 8600:8600/tcp -p 8600:8600/udp \ + hashicorp/consul:1.19 agent -dev -client=0.0.0.0 + - name: Wait for Consul + run: sleep 5 - name: Setup .NET uses: actions/setup-dotnet@v4 with: @@ -372,6 +371,9 @@ jobs: # [SuppressMessage("Microsoft.Security", "CSCAN0090:ConfigFile", Justification="Not a secret")] # [SuppressMessage("Microsoft.Security", "CSCAN0220:DefaultPasswordContexts", Justification="Not a secret")] ORLEANSCONSULCONNECTIONSTRING: "http://localhost:8500" + - name: Clean up Consul container + if: always() + run: docker rm -f consul - name: Archive Test Results if: always() uses: actions/upload-artifact@v4 diff --git a/src/Orleans.TestingHost/TestClusterBuilder.cs b/src/Orleans.TestingHost/TestClusterBuilder.cs index 439eafcd63f..206222f1944 100644 --- a/src/Orleans.TestingHost/TestClusterBuilder.cs +++ b/src/Orleans.TestingHost/TestClusterBuilder.cs @@ -179,7 +179,7 @@ public static string CreateClusterId() string prefix = "testcluster-"; int randomSuffix = Random.Shared.Next(1000); DateTime now = DateTime.UtcNow; - string DateTimeFormat = @"yyyy-MM-dd\tHH-mm-ss"; + string DateTimeFormat = @"yyyy-MM-dd-HH-mm-ss"; return $"{prefix}{now.ToString(DateTimeFormat, CultureInfo.InvariantCulture)}-{randomSuffix}"; }