From 39faa483ae42838a97ad653112e90bf00812d148 Mon Sep 17 00:00:00 2001 From: Rainer Sigwald Date: Thu, 12 Oct 2023 13:40:20 -0500 Subject: [PATCH] Setup UnGAC: treat 259 as success One of the top VS Setup failures is a 259 from our UnGAC, even though we have a big try/catch that should make it never fail. Tell the Setup engine that 259 is another kind of success to keep this nonblocking. Fixes AB#1899796. Co-authored-by: Matt Cavallari --- src/Package/Microsoft.Build.UnGAC/exe.swr | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Package/Microsoft.Build.UnGAC/exe.swr b/src/Package/Microsoft.Build.UnGAC/exe.swr index 9a717021a50..03ae220174d 100644 --- a/src/Package/Microsoft.Build.UnGAC/exe.swr +++ b/src/Package/Microsoft.Build.UnGAC/exe.swr @@ -17,3 +17,8 @@ vs.installSize vs.payloads vs.payload source=$(BinDir)Microsoft.Build.UnGAC.exe + +vs.returnCodes + vs.returnCode type=success + exitCode=259 + details="Suppress return-code 259 since this is a best-effort ."