Skip to content

Include optional logger name in console output if it fails to load #9288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Include optional logger name in console output if it fails to load #9288

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b300dba
Include optional logger name in console output when exception is thro…
yanrez Sep 28, 2023
7445846
Update XMake.cs
yanrez Sep 28, 2023
3aa07b7
Move to resource; make Name public
rainersigwald Sep 28, 2023
18ac0f3
Logger assemblies can be specified by file _or_ name
rainersigwald Sep 29, 2023
4fbf5ac
Expect new message in tests
rainersigwald Sep 29, 2023
b226d70
Merge branch 'vs17.9' into main
rainersigwald Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MSBuild/XMake.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4269,7 +4269,7 @@ private static bool CreateAndConfigureLogger(
}
catch (Exception e) when (loggerDescription.IsOptional)
{
Console.WriteLine(ResourceUtilities.FormatResourceStringStripCodeAndKeyword("OptionalLoggerCreationMessage", e.Message));
Console.WriteLine(loggerDescription.Name ": " + ResourceUtilities.FormatResourceStringStripCodeAndKeyword("OptionalLoggerCreationMessage", e.Message));
return false;
}

Expand Down