diff --git a/eng/Common.globalconfig b/eng/Common.globalconfig index ba417e063f2..2b031559d9a 100644 --- a/eng/Common.globalconfig +++ b/eng/Common.globalconfig @@ -981,7 +981,7 @@ dotnet_diagnostic.SA1502.severity = suggestion dotnet_diagnostic.SA1503.severity = suggestion # All accessors should be single-line or multi-line -dotnet_diagnostic.SA1504.severity = suggestion +dotnet_diagnostic.SA1504.severity = warning # An opening brace should not be followed by a blank line dotnet_diagnostic.SA1505.severity = suggestion diff --git a/src/Build/Construction/Solution/ProjectInSolution.cs b/src/Build/Construction/Solution/ProjectInSolution.cs index 7ccd2e7dfef..5d86bf9a0c5 100644 --- a/src/Build/Construction/Solution/ProjectInSolution.cs +++ b/src/Build/Construction/Solution/ProjectInSolution.cs @@ -150,7 +150,11 @@ internal ProjectInSolution(SolutionFile solution) /// public string RelativePath { - get { return _relativePath; } + get + { + return _relativePath; + } + internal set { #if NETFRAMEWORK && !MONO diff --git a/src/Build/Definition/ProjectItem.cs b/src/Build/Definition/ProjectItem.cs index 592a8a078a1..6dd0d58102c 100644 --- a/src/Build/Definition/ProjectItem.cs +++ b/src/Build/Definition/ProjectItem.cs @@ -184,8 +184,14 @@ public string UnevaluatedInclude { [DebuggerStepThrough] get - { return _xml.Include; } - set { Rename(value); } + { + return _xml.Include; + } + + set + { + Rename(value); + } } /// diff --git a/src/Build/Evaluation/LazyItemEvaluator.OrderedItemDataCollection.cs b/src/Build/Evaluation/LazyItemEvaluator.OrderedItemDataCollection.cs index ac9264ca6dc..34d919b3a7b 100644 --- a/src/Build/Evaluation/LazyItemEvaluator.OrderedItemDataCollection.cs +++ b/src/Build/Evaluation/LazyItemEvaluator.OrderedItemDataCollection.cs @@ -52,7 +52,11 @@ internal Builder(ImmutableList.Builder listBuilder) public ItemData this[int index] { - get { return _listBuilder[index]; } + get + { + return _listBuilder[index]; + } + set { // Update the dictionary if it exists. diff --git a/src/Build/Instance/ProjectInstance.cs b/src/Build/Instance/ProjectInstance.cs index 3777ecbec35..94978503a36 100644 --- a/src/Build/Instance/ProjectInstance.cs +++ b/src/Build/Instance/ProjectInstance.cs @@ -966,8 +966,14 @@ TaskRegistry IEvaluatorData @@ -1074,8 +1080,14 @@ List IEvaluatorData @@ -1086,8 +1098,14 @@ List IEvaluatorData diff --git a/src/Build/Logging/BaseConsoleLogger.cs b/src/Build/Logging/BaseConsoleLogger.cs index e3b892f2b6e..be5fc90a1e8 100644 --- a/src/Build/Logging/BaseConsoleLogger.cs +++ b/src/Build/Logging/BaseConsoleLogger.cs @@ -827,7 +827,11 @@ internal PerformanceCounter(string scopeName) /// internal bool InScope { - get { return inScope; } + get + { + return inScope; + } + set { if (!reenteredScope) diff --git a/src/Framework/ReuseableStringBuilder.cs b/src/Framework/ReuseableStringBuilder.cs index 18457bee6f6..5bd774d5870 100644 --- a/src/Framework/ReuseableStringBuilder.cs +++ b/src/Framework/ReuseableStringBuilder.cs @@ -49,7 +49,11 @@ internal sealed class ReuseableStringBuilder : IDisposable /// public int Length { - get { return _borrowedBuilder?.Length ?? 0; } + get + { + return _borrowedBuilder?.Length ?? 0; + } + set { LazyPrepare(); diff --git a/src/Tasks/AssemblyDependency/Reference.cs b/src/Tasks/AssemblyDependency/Reference.cs index 015ff467546..bff18896103 100644 --- a/src/Tasks/AssemblyDependency/Reference.cs +++ b/src/Tasks/AssemblyDependency/Reference.cs @@ -484,7 +484,11 @@ internal List GetSerializationAssemblyFiles() /// The full path to this assembly. internal string FullPath { - get { return _fullPath; } + get + { + return _fullPath; + } + set { if (_fullPath != value) diff --git a/src/Tasks/AssemblyDependency/ResolveAssemblyReference.cs b/src/Tasks/AssemblyDependency/ResolveAssemblyReference.cs index c6733074229..a9ec79dc413 100644 --- a/src/Tasks/AssemblyDependency/ResolveAssemblyReference.cs +++ b/src/Tasks/AssemblyDependency/ResolveAssemblyReference.cs @@ -322,7 +322,11 @@ public bool IgnoreTargetFrameworkAttributeVersionMismatch /// public string[] TargetFrameworkSubsets { - get { return _targetFrameworkSubsets; } + get + { + return _targetFrameworkSubsets; + } + set { ErrorUtilities.VerifyThrowArgumentNull(value, "TargetFrameworkSubsets"); @@ -450,7 +454,11 @@ public ITaskItem[] InstalledAssemblyTables /// public ITaskItem[] InstalledAssemblySubsetTables { - get { return _installedAssemblySubsetTables; } + get + { + return _installedAssemblySubsetTables; + } + set { ErrorUtilities.VerifyThrowArgumentNull(value, "InstalledAssemblySubsetTables"); @@ -477,7 +485,11 @@ public ITaskItem[] InstalledAssemblySubsetTables /// public ITaskItem[] FullFrameworkAssemblyTables { - get { return _fullFrameworkAssemblyTables; } + get + { + return _fullFrameworkAssemblyTables; + } + set { ErrorUtilities.VerifyThrowArgumentNull(value, "FullFrameworkAssemblyTables"); diff --git a/src/Tasks/GenerateResource.cs b/src/Tasks/GenerateResource.cs index 1b930d2c177..a7e131fd947 100644 --- a/src/Tasks/GenerateResource.cs +++ b/src/Tasks/GenerateResource.cs @@ -252,7 +252,7 @@ public ITaskItem[] FilesWritten } /// - /// The language to use when generating the class source for the strongly typed resource. + /// Gets or sets the language to use when generating the class source for the strongly typed resource. /// This parameter must match exactly one of the languages used by the CodeDomProvider. /// public string StronglyTypedLanguage @@ -263,7 +263,11 @@ public string StronglyTypedLanguage // try to validate it -- that might prevent future expansion of supported languages. _stronglyTypedLanguage = value; } - get { return _stronglyTypedLanguage; } + + get + { + return _stronglyTypedLanguage; + } } ///