Skip to content

Try to deflake ProcessLoggingEventConcurrentWithShutdown_DoesNotThrow #13745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rainersigwald merged 3 commits into from
May 14, 2026
+11 −2
Merged

Try to deflake ProcessLoggingEventConcurrentWithShutdown_DoesNotThrow #13745

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d80be9e
Initial plan
Copilot May 12, 2026
c7b4070
Fix flaky ProcessLoggingEventConcurrentWithShutdown_DoesNotThrow test
Copilot May 12, 2026
edbd945
Address review: drop wordy comments, inline BuildEventContext
Copilot May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/Build.UnitTests/BackEnd/LoggingService_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,7 +1153,12 @@ public void ProcessLoggingEventConcurrentWithShutdown_DoesNotThrow()

LoggingService loggingService = (LoggingService)LoggingService.CreateLoggingService(LoggerMode.Asynchronous, 1);
((IBuildComponent)loggingService).InitializeComponent(mockHost);
loggingService.RegisterLogger(new ConsoleLogger());

loggingService.RegisterLogger(new MockLogger());

Exception loggingThreadException = null;
loggingService.OnLoggingThreadException += ex =>
Interlocked.CompareExchange(ref loggingThreadException, ex, null);

using ManualResetEvent startSignal = new ManualResetEvent(false);
Exception caughtException = null;
Expand All @@ -1166,7 +1171,10 @@ public void ProcessLoggingEventConcurrentWithShutdown_DoesNotThrow()
{
try
{
BuildMessageEventArgs msg = new BuildMessageEventArgs($"Message {i}", null, null, MessageImportance.Low);
BuildMessageEventArgs msg = new BuildMessageEventArgs($"Message {i}", null, null, MessageImportance.Low)
{
BuildEventContext = new BuildEventContext(0, 0, 0, 0),
};
loggingService.ProcessLoggingEvent(msg);
}
catch (Exception ex)
Expand All @@ -1186,6 +1194,7 @@ public void ProcessLoggingEventConcurrentWithShutdown_DoesNotThrow()
bool joined = logThread.Join(TimeSpan.FromSeconds(10));
joined.ShouldBeTrue("Logging thread did not terminate within the allotted time.");
caughtException.ShouldBeNull();
loggingThreadException.ShouldBeNull();
}

#endregion
Expand Down
Loading