Optimize ErrorUtilities several tracing methods for allocation-free message formatting

src/Build/BackEnd/BuildManager/BuildManager.cs

@@ -1727,7 +1727,7 @@ private void LoadSolutionIntoConfiguration(BuildRequestConfiguration config, Bui
                 return;
             }
 
-            ErrorUtilities.VerifyThrow(FileUtilities.IsSolutionFilename(config.ProjectFullPath), "{0} is not a solution", config.ProjectFullPath);
+            ErrorUtilities.VerifyThrow(FileUtilities.IsSolutionFilename(config.ProjectFullPath), $"{config.ProjectFullPath} is not a solution");
 
             var buildEventContext = request.BuildEventContext;
             if (buildEventContext == BuildEventContext.Invalid)
@@ -1899,7 +1899,7 @@ private void ProcessPacket(int node, INodePacket packet)
                         break;
 
                     default:
-                        ErrorUtilities.ThrowInternalError("Unexpected packet received by BuildManager: {0}", packet.Type);
+                        ErrorUtilities.ThrowInternalError($"Unexpected packet received by BuildManager: {packet.Type}");
                         break;
                 }
             }
@@ -2393,7 +2393,7 @@ private void VerifyStateInternal(BuildManagerState requiredState)
         {
             if (_buildManagerState != requiredState)
             {
-                ErrorUtilities.ThrowInternalError("Expected state {0}, actual state {1}", requiredState, _buildManagerState);
+                ErrorUtilities.ThrowInternalError($"Expected state {requiredState}, actual state {_buildManagerState}");
             }
         }
 
@@ -2742,7 +2742,7 @@ private void HandleNodeShutdown(int node, NodeShutdown shutdownPacket)
 
             _shuttingDown = true;
             _executionCancellationTokenSource?.Cancel();
-            ErrorUtilities.VerifyThrow(_activeNodes.Contains(node), "Unexpected shutdown from node {0} which shouldn't exist.", node);
+            ErrorUtilities.VerifyThrow(_activeNodes.Contains(node), $"Unexpected shutdown from node {node} which shouldn't exist.");
             _activeNodes.Remove(node);
 
             if (shutdownPacket.Reason != NodeShutdownReason.Requested)
@@ -2945,7 +2945,7 @@ private void PerformSchedulingActions(IEnumerable<ScheduleResponse> responses)
                         break;
 
                     default:
-                        ErrorUtilities.ThrowInternalError("Scheduling action {0} not handled.", response.Action);
+                        ErrorUtilities.ThrowInternalError($"Scheduling action {response.Action} not handled.");
                         break;
                 }
             }
@@ -3381,17 +3381,14 @@ private static void LogDeferredMessages(ILoggingService loggingService, IEnumera
         /// Ensures that the packet type matches the expected type
         /// </summary>
         /// <typeparam name="I">The instance-type of packet being expected</typeparam>
-        private static I ExpectPacketType<I>(INodePacket packet, NodePacketType expectedType) where I : class, INodePacket
+        private static I ExpectPacketType<I>(INodePacket packet, NodePacketType expectedType)
+            where I : class, INodePacket
         {
             I? castPacket = packet as I;
 
-            // PERF: Not using VerifyThrow here to avoid boxing of expectedType.
-            if (castPacket == null)
-            {
-                ErrorUtilities.ThrowInternalError("Incorrect packet type: {0} should have been {1}", packet.Type, expectedType);
-            }
+            ErrorUtilities.VerifyThrow(castPacket != null, $"Incorrect packet type: {packet.Type} should have been {expectedType}");
 
-            return castPacket!;
+            return castPacket;
         }
 
         /// <summary>

src/Build/BackEnd/BuildManager/BuildSubmission.cs

@@ -227,8 +227,7 @@ protected internal override void CheckResultValidForCompletion(BuildResult resul
             // this one.)
             if (result.ConfigurationId != BuildRequest?.ConfigurationId)
             {
-                ErrorUtilities.ThrowInternalError("BuildResult configuration ({0}) doesn't match BuildRequest configuration ({1})",
-                    result.ConfigurationId, BuildRequest?.ConfigurationId);
+                ErrorUtilities.ThrowInternalError($"BuildResult configuration ({result.ConfigurationId}) doesn't match BuildRequest configuration ({BuildRequest?.ConfigurationId})");
             }
         }
 

src/Build/BackEnd/BuildManager/LegacyThreadingData.cs

@@ -88,7 +88,7 @@ internal void RegisterSubmissionForLegacyThread(int submissionId)
         {
             lock (_legacyThreadingEventsLock)
             {
-                ErrorUtilities.VerifyThrow(!_legacyThreadingEventsById.ContainsKey(submissionId), "Submission {0} should not already be registered with LegacyThreadingData", submissionId);
+                ErrorUtilities.VerifyThrow(!_legacyThreadingEventsById.ContainsKey(submissionId), $"Submission {submissionId} should not already be registered with LegacyThreadingData");
 
                 _legacyThreadingEventsById[submissionId] = new Tuple<AutoResetEvent, ManualResetEvent>(
                                 new AutoResetEvent(false),
@@ -104,7 +104,7 @@ internal void UnregisterSubmissionForLegacyThread(int submissionId)
         {
             lock (_legacyThreadingEventsLock)
             {
-                ErrorUtilities.VerifyThrow(_legacyThreadingEventsById.ContainsKey(submissionId), "Submission {0} should have been previously registered with LegacyThreadingData", submissionId);
+                ErrorUtilities.VerifyThrow(_legacyThreadingEventsById.ContainsKey(submissionId), $"Submission {submissionId} should have been previously registered with LegacyThreadingData");
 
                 // Dispose the events
                 _legacyThreadingEventsById[submissionId].Item1?.Dispose();
@@ -127,7 +127,7 @@ internal WaitHandle GetStartRequestBuilderMainThreadEventForSubmission(int submi
                 _legacyThreadingEventsById.TryGetValue(submissionId, out legacyThreadingEvents);
             }
 
-            ErrorUtilities.VerifyThrow(legacyThreadingEvents != null, "We're trying to wait on the legacy thread for submission {0}, but that submission has not been registered.", submissionId);
+            ErrorUtilities.VerifyThrow(legacyThreadingEvents != null, $"We're trying to wait on the legacy thread for submission {submissionId}, but that submission has not been registered.");
 
             return legacyThreadingEvents.Item1;
         }
@@ -145,7 +145,7 @@ internal Task GetLegacyThreadInactiveTask(int submissionId)
                 _legacyThreadingEventsById.TryGetValue(submissionId, out legacyThreadingEvents);
             }
 
-            ErrorUtilities.VerifyThrow(legacyThreadingEvents != null, "We're trying to track when the legacy thread for submission {0} goes inactive, but that submission has not been registered.", submissionId);
+            ErrorUtilities.VerifyThrow(legacyThreadingEvents != null, $"We're trying to track when the legacy thread for submission {submissionId} goes inactive, but that submission has not been registered.");
 
             return legacyThreadingEvents.Item2.ToTask();
         }
@@ -168,7 +168,7 @@ internal void SignalLegacyThreadStart(RequestBuilder instance)
                 _legacyThreadingEventsById.TryGetValue(submissionId, out legacyThreadingEvents);
             }
 
-            ErrorUtilities.VerifyThrow(legacyThreadingEvents != null, "We're trying to signal that the legacy thread is ready for submission {0} to execute, but that submission has not been registered", submissionId);
+            ErrorUtilities.VerifyThrow(legacyThreadingEvents != null, $"We're trying to signal that the legacy thread is ready for submission {submissionId} to execute, but that submission has not been registered");
 
             // signal that this submission is currently controlling the legacy thread
             legacyThreadingEvents.Item1.Set();
@@ -190,7 +190,7 @@ internal void SignalLegacyThreadEnd(int submissionId)
                 _legacyThreadingEventsById.TryGetValue(submissionId, out legacyThreadingEvents);
             }
 
-            ErrorUtilities.VerifyThrow(legacyThreadingEvents != null, "We're trying to signal that submission {0} is done with the legacy thread, but that submission has not been registered", submissionId);
+            ErrorUtilities.VerifyThrow(legacyThreadingEvents != null, $"We're trying to signal that submission {submissionId} is done with the legacy thread, but that submission has not been registered");
 
             // The legacy thread is now idle
             legacyThreadingEvents.Item2.Set();

src/Build/BackEnd/Client/MSBuildClientPacketPump.cs

@@ -261,7 +261,7 @@ private void RunReadLoop(Stream localStream, ManualResetEvent localPacketPumpShu
                                     }
                                     else
                                     {
-                                        ErrorUtilities.ThrowInternalError("Incomplete header read.  {0} of {1} bytes read", headerBytesRead, headerByte.Length);
+                                        ErrorUtilities.ThrowInternalError($"Incomplete header read.  {headerBytesRead} of {headerByte.Length} bytes read");
                                     }
                                 }
 
@@ -321,7 +321,7 @@ private void RunReadLoop(Stream localStream, ManualResetEvent localPacketPumpShu
                             break;
 
                         default:
-                            ErrorUtilities.ThrowInternalError("WaitId {0} out of range.", waitId);
+                            ErrorUtilities.ThrowInternalError($"WaitId {waitId} out of range.");
                             break;
                     }
                 }

src/Build/BackEnd/Components/BuildComponentFactoryCollection.cs

@@ -136,7 +136,7 @@ public void ReplaceFactory(BuildComponentType componentType, BuildComponentFacto
         /// <param name="instance">The instance to be registered.</param>
         public void ReplaceFactory(BuildComponentType componentType, IBuildComponent instance)
         {
-            ErrorUtilities.VerifyThrow(_componentEntriesByType[componentType].Pattern == CreationPattern.Singleton, "Previously existing factory for type {0} was not a singleton factory.", componentType);
+            ErrorUtilities.VerifyThrow(_componentEntriesByType[componentType].Pattern == CreationPattern.Singleton, $"Previously existing factory for type {componentType} was not a singleton factory.");
             _componentEntriesByType[componentType] = new BuildComponentEntry(componentType, instance);
         }
 
@@ -160,7 +160,7 @@ public IBuildComponent GetComponent(BuildComponentType type)
         {
             if (!_componentEntriesByType.TryGetValue(type, out BuildComponentEntry componentEntry))
             {
-                ErrorUtilities.ThrowInternalError("No factory registered for component type {0}", type);
+                ErrorUtilities.ThrowInternalError($"No factory registered for component type {type}");
             }
 
             return componentEntry.GetInstance(_host);