Skip to content

Avoid conhost processes for worker nodes on Windows #12356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rainersigwald merged 3 commits into from
Aug 19, 2025
Merged

Avoid conhost processes for worker nodes on Windows #12356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee48513
Add DETACHED_PROCESS flag to CreateProcess call for Windows nodes
rainersigwald Aug 15, 2025
83881a1
fixup! Add DETACHED_PROCESS flag to CreateProcess call for Windows nodes
rainersigwald Aug 15, 2025
17a8a2f
uint->Int32
rainersigwald Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Build/BackEnd/Components/Communications/NodeLauncher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,12 @@ private Process StartInternal(string msbuildLocation, string commandLineArgs)
startInfo.hStdInput = BackendNativeMethods.InvalidHandle;
startInfo.hStdOutput = BackendNativeMethods.InvalidHandle;
startInfo.dwFlags = BackendNativeMethods.STARTFUSESTDHANDLES;

creationFlags |= BackendNativeMethods.CREATENOWINDOW;

// Avoid spawning a conhost.exe process, since this node won't do console output
// even though Windows thinks of us as a "console process"
creationFlags |= BackendNativeMethods.DETACHED_PROCESS;
}
}
else
Expand Down
5 changes: 5 additions & 0 deletions src/Build/BackEnd/Node/NativeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ internal static class NativeMethods
/// </summary>
internal const Int32 CREATE_NEW_CONSOLE = 0x00000010;

/// <summary>
/// For console processes, the new process does not inherit its parent's console (the default).
/// </summary>
internal const Int32 DETACHED_PROCESS = 0x00000008;

/// <summary>
/// Create a new process
/// </summary>
Expand Down
Loading