Skip to content

[vs17.14] Binlog not produced for C++ project on Visual Studio Load Fix #11774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025
Merged

[vs17.14] Binlog not produced for C++ project on Visual Studio Load Fix #11774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa56f50
fix attaching binlog
surayya-MS Apr 28, 2025
8a431a0
fix another misplaced brackets
surayya-MS Apr 28, 2025
12b9b30
bump version
surayya-MS Apr 28, 2025
2dba1b2
Further version bump
rainersigwald Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the MIT license. See License.txt in the project root for full license information. -->
<Project>
<PropertyGroup>
<VersionPrefix>17.14.4</VersionPrefix><DotNetFinalVersionKind>release</DotNetFinalVersionKind>
<VersionPrefix>17.14.7</VersionPrefix><DotNetFinalVersionKind>release</DotNetFinalVersionKind>
<PackageValidationBaselineVersion>17.13.9</PackageValidationBaselineVersion>
<AssemblyVersion>15.1.0.0</AssemblyVersion>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
Expand Down
2 changes: 1 addition & 1 deletion src/Build/BackEnd/BuildManager/BuildManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ IEnumerable<ILogger> AppendDebuggingLoggers(IEnumerable<ILogger> loggers)

var logger = new BinaryLogger { Parameters = binlogPath };

return (loggers ?? [logger]);
return (loggers ?? []).Concat([logger]);
}

void InitializeCaches()
Expand Down
2 changes: 1 addition & 1 deletion src/Tasks/GenerateResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1705,7 +1705,7 @@ private void UpdateNewestUncorrelatedInputWriteTime()

// Check the timestamp of each of the passed-in references to find the newest;
// and then the additional inputs
ITaskItem[] inputs = this.References ?? [.. (this.AdditionalInputs ?? [])];
var inputs = (this.References ?? []).Concat(this.AdditionalInputs ?? []);

foreach (ITaskItem input in inputs)
{
Expand Down