Skip to content

Commit e95e7d3

Browse files
authored
Fail with clear error message when reporting file accesses with unsupported arch (#9241)
Follow-up change from #9214.
1 parent c97a9a7 commit e95e7d3

File tree

15 files changed

+71
-0
lines changed

15 files changed

+71
-0
lines changed

src/Build/BackEnd/BuildManager/BuildManager.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -728,6 +728,9 @@ void InitializeCaches()
728728
[MethodImpl(MethodImplOptions.NoInlining)]
729729
private void EnableDetouredNodeLauncher()
730730
{
731+
// Currently BuildXL only supports x64. Once this feature moves out of the experimental phase, this will need to be addressed.
732+
ErrorUtilities.VerifyThrowInvalidOperation(NativeMethodsShared.ProcessorArchitecture == NativeMethodsShared.ProcessorArchitectures.X64, "ReportFileAccessesX64Only");
733+
731734
// To properly report file access, we need to disable the in-proc node which won't be detoured.
732735
_buildParameters.DisableInProcNode = true;
733736

src/Build/Resources/Strings.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1998,6 +1998,9 @@ Utilization: {0} Average Utilization: {1:###.0}</value>
19981998
<value>MSB4277: Cannot copy from object of that type.</value>
19991999
<comment>{StrBegin="MSB4277: "}</comment>
20002000
</data>
2001+
<data name="ReportFileAccessesX64Only" xml:space="preserve">
2002+
<value>Reporting file accesses is only currently supported using the x64 flavor of MSBuild.</value>
2003+
</data>
20012004
<!--
20022005
The Build message bucket is: MSB4000 - MSB4999
20032006

src/Build/Resources/xlf/Strings.cs.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Build/Resources/xlf/Strings.de.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Build/Resources/xlf/Strings.es.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Build/Resources/xlf/Strings.fr.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Build/Resources/xlf/Strings.it.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Build/Resources/xlf/Strings.ja.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Build/Resources/xlf/Strings.ko.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Build/Resources/xlf/Strings.pl.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)