[automated] Merge branch 'vs17.11' => 'vs17.12' (#12487)

Author: JanProvaznik

.vsts-dotnet.yml

@@ -6,7 +6,6 @@ trigger:
 # Once they exist, we should define these as "runtime parameters"
 # https://github.com/Microsoft/azure-pipelines-yaml/pull/129
 # variables:
-#   SignType: real
 #   SkipApplyOptimizationData: false
 
 parameters:
@@ -22,6 +21,10 @@ parameters:
   displayName: Enable Signing Validation
   type: boolean
   default: true
+- name: signTypeParameter
+  displayName: Sign Type
+  type: string
+  default: 'real'
 
 variables:
   # if OptProfDrop is not set, string '$(OptProfDrop)' will be passed to the build script.
@@ -120,6 +123,7 @@ extends:
         parameters:
           isExperimental: false
           enableComponentGovernance: true
+          signTypeParameter: ${{ parameters.signTypeParameter }}
           enableOptProf: ${{ parameters.enableOptProf }}
 
     - template: /eng/common/templates-official/post-build/post-build.yml@self

azure-pipelines/.vsts-dotnet-build-jobs.yml

@@ -6,6 +6,9 @@ parameters:
 - name: enableComponentGovernance
   type: boolean
   default: false
+- name: signTypeParameter
+  type: string
+  default: 'test'
 - name: enableOptProf
   type: boolean
   default: false
@@ -45,6 +48,7 @@ jobs:
     env:
       Token: $(dn-bot-dnceng-artifact-feeds-rw)
 
+
   - task: NuGetCommand@2
     displayName: Restore internal tools
     inputs:
@@ -57,14 +61,14 @@ jobs:
   - task: MicroBuildSigningPlugin@4
     displayName: Install MicroBuild plugin
     inputs:
-      signType: $(SignType)
+      signType: ${{ parameters.signTypeParameter }}
       zipSources: false
       feedSource: https://devdiv.pkgs.visualstudio.com/_packaging/MicroBuildToolset/nuget/v3/index.json
-      ${{ if and(eq(variables['SignType'], 'real'), eq(variables['System.TeamProject'], 'DevDiv')) }}:
+      ${{ if and(eq(parameters.signTypeParameter, 'real'), eq(variables['System.TeamProject'], 'DevDiv')) }}:
         ConnectedPMEServiceName: 6cc74545-d7b9-4050-9dfa-ebefcc8961ea
     env:
       SYSTEM_ACCESSTOKEN: $(System.AccessToken)
-    condition: and(succeeded(), in(variables['SignType'], 'test', 'real'))
+    condition: and(succeeded(), in('${{ parameters.signTypeParameter }}', 'test', 'real'))
 
   - task: MicroBuildOptProfPlugin@6
     inputs:
@@ -88,12 +92,14 @@ jobs:
               /p:VisualStudioIbcSourceBranchName=$(SourceBranch)
               /p:VisualStudioDropAccessToken=$(System.AccessToken)
               /p:VisualStudioDropName=$(VisualStudio.DropName)
-              /p:DotNetSignType=$(SignType)
+              /p:DotNetSignType=${{ parameters.signTypeParameter }}
               /p:TeamName=MSBuild
               /p:DotNetPublishUsingPipelines=true
               /p:VisualStudioIbcDrop=$(OptProfDrop)
               /p:GenerateSbom=true
               /p:SuppressFinalPackageVersion=${{ parameters.isExperimental }}
+              /p:IsExperimental=${{ parameters.isExperimental }}
+
     displayName: Build
     condition: succeeded()
 

azure-pipelines/.vsts-dotnet-exp-perf.yml

@@ -6,7 +6,6 @@ trigger:
 # Once they exist, we should define these as "runtime parameters"
 # https://github.com/Microsoft/azure-pipelines-yaml/pull/129
 # variables:
-#   SignType: test
 #   SkipApplyOptimizationData: false
 
 parameters:
@@ -18,6 +17,10 @@ parameters:
   displayName: Enable Signing Validation
   type: boolean
   default: false
+- name: signTypeParameter
+  displayName: Sign Type
+  type: string
+  default: 'test'
 - name: enableOptProf
   displayName: Enable OptProf data collection for this build
   type: boolean
@@ -77,6 +80,7 @@ extends:
         parameters:
           isExperimental: true
           enableComponentGovernance: false
+          signTypeParameter: ${{ parameters.signTypeParameter }}
           enableOptProf: ${{ parameters.enableOptProf }}
 
     - template: /eng/common/templates/post-build/post-build.yml@self

azure-pipelines/vs-insertion-experimental.yml

@@ -180,3 +180,4 @@ extends:
             InsertionReviewers: MSBuild
             CustomScriptExecutionCommand: $(InsertCustomScriptExecutionCommand)
             InsertionBuildPolicy: Request Perf DDRITs
+

eng/Versions.props

@@ -2,11 +2,15 @@
 <!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the MIT license. See License.txt in the project root for full license information. -->
 <Project>
   <PropertyGroup>
-    <VersionPrefix>17.12.48</VersionPrefix>
+    <VersionPrefix>17.12.49</VersionPrefix>
     <DotNetFinalVersionKind>release</DotNetFinalVersionKind>
     <PackageValidationBaselineVersion>17.11.4</PackageValidationBaselineVersion>
     <AssemblyVersion>15.1.0.0</AssemblyVersion>
     <PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
+
+    <!-- differentiate experimental insertions to avoid package id conflicts, 
+    it has to be alphabetically after "preview" to avoid downgrade errors in VS -->
+    <PreReleaseVersionLabel Condition="'$(IsExperimental)' == 'true'">test</PreReleaseVersionLabel>
     <DotNetUseShippingVersions>true</DotNetUseShippingVersions>
     <!-- Workaround for https://github.com/dotnet/roslyn/issues/35793 -->
     <SemanticVersioningV1>true</SemanticVersioningV1>