Skip to content

Implement TextDecorations property in WinUI LabelHandler#726

Merged
jsuarezruiz merged 3 commits into
mainfrom
winui-label-textdecorations
Apr 23, 2021
Merged

Implement TextDecorations property in WinUI LabelHandler#726
jsuarezruiz merged 3 commits into
mainfrom
winui-label-textdecorations

Conversation

@jsuarezruiz
Copy link
Copy Markdown
Contributor

Description of Change

Implement TextDecorations property in WinUI LabelHandler.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might effect accessibility?

No

@PureWeen PureWeen force-pushed the winui-label-textdecorations branch from 44f9444 to fc48a91 Compare April 16, 2021 01:24
@rachelkang rachelkang self-requested a review April 22, 2021 16:55
Copy link
Copy Markdown
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reloadify NRE and layout bug needs to be resolved
Otherwise, this property LGTM!

@jsuarezruiz jsuarezruiz merged commit 7c18947 into main Apr 23, 2021
@jsuarezruiz jsuarezruiz deleted the winui-label-textdecorations branch April 23, 2021 07:45
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.4 Look for this fix in 6.0.100-preview.4! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

fixed-in-6.0.100-preview.4 Look for this fix in 6.0.100-preview.4! platform/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants