From 79b2fd0633c73bfe667aefa483bd2e24c978b4b2 Mon Sep 17 00:00:00 2001
From: Copilot <223556219+Copilot@users.noreply.github.com>
Date: Sun, 26 Jul 2026 09:42:30 +0200
Subject: [PATCH] Add missing YAML frontmatter to find-regression-risk SKILL.md

The `find-regression-risk` skill had no YAML frontmatter, so Copilot CLI
failed to load it with:

    The following skills failed to load:
    * .github/skills/find-regression-risk/SKILL.md: missing or malformed YAML frontmatter

Every other skill under `.github/skills/` starts with a `---` block
declaring at least `name` and `description`; this one was the only
exception, which made it invisible to the CLI skill loader and to
vally's skill linter.

Adds a frontmatter block matching the conventions used by the sibling
skills (`name`, `description`, `metadata.author`, `metadata.version`,
`compatibility`), with a description covering the skill's purpose,
trigger phrases, and "Do NOT use for" guidance.

Also refreshes the now-stale comment in `skill-validation.yml`, which
listed this missing frontmatter as one of two pre-existing lint failures
justifying why SKILL.md linting is skipped in that gate. Only the
try-fix 500-line issue remains.

Verified with the same linter the workflow pins:

    npx @microsoft/vally-cli@0.10.0 lint .github/skills/find-regression-risk
    -> find-regression-risk (2/2 checks passed)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: fedc0275-f17d-4af4-af1b-df406fa722a0
---
 .github/skills/find-regression-risk/SKILL.md | 18 ++++++++++++++++++
 .github/workflows/skill-validation.yml       |  7 +++----
 2 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/.github/skills/find-regression-risk/SKILL.md b/.github/skills/find-regression-risk/SKILL.md
index d458232359e8..27b361b95ca1 100644
--- a/.github/skills/find-regression-risk/SKILL.md
+++ b/.github/skills/find-regression-risk/SKILL.md
@@ -1,3 +1,21 @@
+---
+name: find-regression-risk
+description: >-
+  Detects potential regression risks in a PR by cross-referencing lines the PR
+  REMOVES against lines ADDED by recent labeled bug-fix PRs (`i/regression`,
+  `t/bug`, `p/0`, `p/1`) touching the same files. Purely mechanical — no AI/LLM.
+  Emits a CLEAN / OVERLAP / REVERT verdict plus structured findings. Triggers on:
+  "does this PR revert a previous fix", "check PR for regression risk",
+  "find regression risks in PR", "is this change reverting a bug fix".
+  Do NOT use for: assessing ship-readiness of a release branch (use
+  release-readiness), investigating CI failures (use azdo-build-investigator),
+  or general code review (use code-review).
+metadata:
+  author: dotnet-maui
+  version: "1.0"
+compatibility: Requires PowerShell (pwsh), git, and GitHub CLI (gh) authenticated against the target repository.
+---
+
 # find-regression-risk
 
 Detects potential regression risks in a PR by cross-referencing removed lines against lines added by recent labeled bug-fix PRs.
diff --git a/.github/workflows/skill-validation.yml b/.github/workflows/skill-validation.yml
index 96b2a4e2abd3..460274332a92 100644
--- a/.github/workflows/skill-validation.yml
+++ b/.github/workflows/skill-validation.yml
@@ -254,10 +254,9 @@ jobs:
       # nonstandard filename with --eval-spec. This also SKIPS SKILL.md structural
       # linting. We do NOT
       # lint SKILL.md / *.agent.md here on purpose: vally's skill linter flags
-      # two PRE-EXISTING repo issues unrelated to this migration (try-fix
-      # SKILL.md exceeds the 500-line limit; find-regression-risk is missing
-      # name/description frontmatter) that would false-red this gate. Those are
-      # tracked as follow-ups in the PR description.
+      # a PRE-EXISTING repo issue unrelated to this migration (try-fix
+      # SKILL.md exceeds the 500-line limit) that would false-red this gate.
+      # That is tracked as a follow-up in the PR description.
       - name: Lint eval specs
         id: check
         shell: bash