-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Testing] Fixed Test case failure in net10 branch - 2 #32224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,11 @@ public void ToolbarExtendsAllTheWayLeftAndRight_NavigationPage() | |
| App.WaitForElement("ContentGrid"); | ||
| App.SetOrientationLandscape(); | ||
| App.WaitForElement("ContentGrid"); | ||
| #if ANDROID | ||
| VerifyScreenshot(cropLeft: 125); | ||
|
||
| #else | ||
| VerifyScreenshot(); | ||
| #endif | ||
| } | ||
| } | ||
| #endif | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,11 @@ public void ToolbarExtendsAllTheWayLeftAndRight_Shell() | |
| App.WaitForElement("ContentGrid"); | ||
| App.SetOrientationLandscape(); | ||
| App.WaitForElement("ContentGrid"); | ||
| #if ANDROID | ||
| VerifyScreenshot(cropLeft: 125); | ||
|
||
| #else | ||
| VerifyScreenshot(); | ||
| #endif | ||
| } | ||
| } | ||
| #endif | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The magic number 125 is duplicated from the other Issue28986 test files. Consider extracting this value to a shared named constant (e.g.,
AndroidLandscapeNavigationBarWidth) to maintain consistency across all three toolbar tests.