From e0ffaf0c4c1623f4e2635207fa6e48f35b2bc5b9 Mon Sep 17 00:00:00 2001 From: Stephane Delcroix Date: Fri, 17 Oct 2025 22:01:08 +0200 Subject: [PATCH] [XSG] enable diagnostis by default on Debug if EnableDiagnostics isn't set, defaut to true on Debug builds - fixes #32047 [XSG] enable diagnostis by default on Debug if EnableDiagnostics isn't set, defaut to true on Debug builds - fixes #32047 --- .../netstandard2.0/Microsoft.Maui.Controls.Common.targets | 1 + src/Controls/src/SourceGen/ProjectItem.cs | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/Controls/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/Microsoft.Maui.Controls.Common.targets b/src/Controls/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/Microsoft.Maui.Controls.Common.targets index a0ee8d347f34..55462cab2279 100644 --- a/src/Controls/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/Microsoft.Maui.Controls.Common.targets +++ b/src/Controls/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/Microsoft.Maui.Controls.Common.targets @@ -29,5 +29,6 @@ + diff --git a/src/Controls/src/SourceGen/ProjectItem.cs b/src/Controls/src/SourceGen/ProjectItem.cs index 63c18b382a55..c1e3bc5f2056 100644 --- a/src/Controls/src/SourceGen/ProjectItem.cs +++ b/src/Controls/src/SourceGen/ProjectItem.cs @@ -32,7 +32,11 @@ public bool EnableDiagnostics return true; if (Options.IsFalse("build_metadata.additionalfiles.EnableDiagnostics")) return false; - return Options.IsTrue("build_property.EnableMauiXamlDiagnostics"); + if (Options.IsTrue("build_property.EnableMauiXamlDiagnostics")) + return true; + if (Options.IsFalse("build_property.EnableMauiXamlDiagnostics")) + return false; + return !Configuration.Equals("Release", StringComparison.OrdinalIgnoreCase); } }