-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixed Stepper allows incrementing beyond the maximum value #28398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey there @SubhikshaSf4851! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses a bug where the Stepper permitted incrementing beyond its maximum value when the minimum and maximum were equal.
- Changed the validation logic in Stepper.cs to allow maximum and minimum to be equal instead of requiring strict inequality.
- Added/updated test cases in both HostApp and Shared.Tests to verify that increment and decrement actions are disabled when the value equals the boundary.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.HostApp/Issues/Issue28330.cs | Hosts a test page to visually check the stepper’s behavior on various platforms. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28330.cs | Contains automated UI tests ensuring the stepper does not increment or decrement when at its limits. |
| src/Controls/src/Core/Stepper/Stepper.cs | Updates the validation conditions for Maximum and Minimum properties to allow equality. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
* Fix for stepper allows to increment value * Updating naming concern * Updates on minimum value and test case sample
* Fix for stepper allows to increment value * Updating naming concern * Updates on minimum value and test case sample
* Fix for stepper allows to increment value * Updating naming concern * Updates on minimum value and test case sample
Root cause:
Description of Change:
Tested the behaviour in the following platforms
Issue Fixed:
Fixes: #28330
Output
Issue28330BeforeFix.mp4
Issue28330AfterFix.mp4