[Windows] Remove workaround for label text decorations

[MartyIX]

Description of Change

According to microsoft/microsoft-ui-xaml#1093 (comment) the issue microsoft/microsoft-ui-xaml#1093 should be fixed in WinUI 3 in WinAppSDK 1.4. Removed code was added in #726 which was three years ago. The issue was fixed last year.

Performance impact

Two measurements for main branch:

• Maui.Controls.Sample.Sandbox.exe_20240526_100801.speedscope.MAIN1.json
• Maui.Controls.Sample.Sandbox.exe_20240526_101614.speedscope.MAIN2.json

Two measurements for the PR branch:

• Maui.Controls.Sample.Sandbox.exe_20240526_101123.speedscope.PR1.json
• Maui.Controls.Sample.Sandbox.exe_20240526_101346.speedscope.PR2.json

-> 98% improvement. It's really big so that's why I did second measurements but it appears that it really has big impact (on all labels). Anyway, even the measurements were wrong, from performance point of view doing less takes less time.

Issues Fixed

Contributes to #21787

[dotnet-policy-service]

Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[MartyIX]

I have verified that the code still works using sandbox (branch, MartyIX@b9c7f17) which simply does:

MainPage.xaml.cs

<ContentPage
    xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
    x:Class="Maui.Controls.Sample.MainPage"
    xmlns:local="clr-namespace:Maui.Controls.Sample">
  <VerticalStackLayout>
    <Label x:Name="myLabel" Text="This is the text"/>
    <Button Text="Click me" Clicked="Button_Clicked"/>
  </VerticalStackLayout>
</ContentPage>

MainPage.cs

using System;
using System.Collections.ObjectModel;
using System.Diagnostics;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Maui;
using Microsoft.Maui.Controls;
using Microsoft.Maui.Graphics;

namespace Maui.Controls.Sample
{
	public partial class MainPage : ContentPage
	{
		private int i = 0;

		public MainPage()
		{
			InitializeComponent();
		}

		private void Button_Clicked(object sender, EventArgs e)
		{
			i++;
			if (i % 2 == 1)
			{
				myLabel.TextDecorations = TextDecorations.Underline | TextDecorations.Strikethrough;
			}
			else
			{
				myLabel.TextDecorations = TextDecorations.None;
			}
		}
    }
}

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/azp run

[jsuarezruiz]

I have verified that the code still works using sandbox (branch, MartyIX@b9c7f17) which simply does:

MainPage.xaml.cs

<ContentPage
    xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
    x:Class="Maui.Controls.Sample.MainPage"
    xmlns:local="clr-namespace:Maui.Controls.Sample">
  <VerticalStackLayout>
    <Label x:Name="myLabel" Text="This is the text"/>
    <Button Text="Click me" Clicked="Button_Clicked"/>
  </VerticalStackLayout>
</ContentPage>

MainPage.cs

using System;
using System.Collections.ObjectModel;
using System.Diagnostics;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Maui;
using Microsoft.Maui.Controls;
using Microsoft.Maui.Graphics;

namespace Maui.Controls.Sample
{
	public partial class MainPage : ContentPage
	{
		private int i = 0;

		public MainPage()
		{
			InitializeComponent();
		}

		private void Button_Clicked(object sender, EventArgs e)
		{
			i++;
			if (i % 2 == 1)
			{
				myLabel.TextDecorations = TextDecorations.Underline | TextDecorations.Strikethrough;
			}
			else
			{
				myLabel.TextDecorations = TextDecorations.None;
			}
		}
    }
}

Used to include an UITest.

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[MartyIX]

Thank you

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[Foda]

Great contribution! Thank you!