Add switch to BlazorWebView to configure 'fire and forget' for Android Disposal#22496
Merged
Conversation
PureWeen
previously approved these changes
May 17, 2024
jsuarezruiz
approved these changes
May 20, 2024
MackinnonBuck
approved these changes
May 20, 2024
| return blazorAndroidWebView; | ||
| } | ||
|
|
||
| private const string AndroidFireAndForgetAsyncSwitch = "BlazorWebView.AndroidFireAndForgetAsync"; |
Member
There was a problem hiding this comment.
Not to bikeshed, but would "BlazorWebView.AndroidFireAndForgetDisposeAsync" be more targeted toward the specific change in behavior?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Add an opt-in switch to enable the BlazorWebView to 'fire and forget' the async disposal that occurs in BlazorWebView. By default, the BlazorWebView does async-over-sync for disposal, meaning that it blocks the thread until the async disposal is complete. Unfortunately, this can cause deadlocks if the disposal itself needs to run code on the same thread (because that thread is blocked while waiting). The control has had this logic for a long time, but it seems that on Android the luck has changed, and hangs are now quite common during disposal.
By default there is no behavior change.
If you are encountering hangs in Android with BlazorWebView, you can enable this AppContext Switch with one line of code in your app's
MauiProgram.cs:This issue has been reported in several different issues, but we think they all have this same root cause, and enabling this new switch should fix your app.
Confirmed fixed by this PR:
Hard to test, but seem to be exactly the same issue:
Caveats
Because enabling this new switch means that disposal can return before all objects are disposed, this can cause behavioral changes in an app. The items that are disposed are partially Blazor's own internal types, but also app-defined types such as scoped services used within the BlazorWebView portion of the app.
Issues Fixed
Fixes #13529