Skip to content

App Crash during Scroll Animation while navigating away from Page - fix#22492

Merged
PureWeen merged 3 commits into
dotnet:mainfrom
kubaflo:fix-22443
May 21, 2024
Merged

App Crash during Scroll Animation while navigating away from Page - fix#22492
PureWeen merged 3 commits into
dotnet:mainfrom
kubaflo:fix-22443

Conversation

@kubaflo
Copy link
Copy Markdown
Contributor

@kubaflo kubaflo commented May 17, 2024

Issues Fixed

Fixes #22443

@kubaflo kubaflo requested a review from a team as a code owner May 17, 2024 14:45
@kubaflo kubaflo requested review from Eilon and StephaneDelcroix May 17, 2024 14:45
@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label May 17, 2024
Comment thread src/Core/src/Handlers/ScrollView/ScrollViewHandler.Android.cs Outdated
@Eilon Eilon added the area-animation Animation, Transitions, Transforms label May 17, 2024
@kubaflo kubaflo force-pushed the fix-22443 branch 3 times, most recently from a474098 to b81de09 Compare May 17, 2024 18:19
@PureWeen
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen enabled auto-merge (squash) May 17, 2024 19:33
public override string Issue => "App Crash on Scroll Animation while navigating away from Page";

[Test]
public void NoExceptionShouldBeThrown()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is failing on catalyst

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-19 at 00 57 28 Should work now :)

auto-merge was automatically disabled May 18, 2024 17:52

Head branch was pushed to by a user without write access

@PureWeen
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen enabled auto-merge (squash) May 19, 2024 00:03
@PATRICKdallat
Copy link
Copy Markdown

Not a fix, just a cover up/workaround.
Please take a look at my comment in the bug ticket linked below.
#22443 (comment)

@jsuarezruiz jsuarezruiz self-requested a review May 21, 2024 13:45
@PureWeen
Copy link
Copy Markdown
Member

Failing test isn't related

@PureWeen PureWeen disabled auto-merge May 21, 2024 20:26
@PureWeen PureWeen merged commit 7ad1b69 into dotnet:main May 21, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App Crash on Android due to ScrollViewHandler.DisconnectHandler call during Scroll Animation while navigating away from Page.

6 participants