[Windows] Clamp images inside buttons to button width/height#22276
Merged
Conversation
added 7 commits
April 9, 2024 09:52
…tton doesn't have a width or height set
# Conflicts: # src/Controls/tests/UITests/snapshots/windows/Issue21513Test.png
jsuarezruiz
reviewed
May 9, 2024
Member
|
As @jsuarezruiz noticed, the image is clipped. But if you look at all the other images, they are all clipping now. Or rather, still clipping. Should they? |
added 2 commits
May 9, 2024 12:01
Contributor
jsuarezruiz
approved these changes
May 15, 2024
mattleibow
approved these changes
May 15, 2024
Member
mattleibow
left a comment
There was a problem hiding this comment.
Looks good!
Not sure if there is value in a device test for Windows that picks a few sizes/options and then renders it on screen. The test would be to make sure the position of things are where they are expected to be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of Change
This PR forces images inside buttons to always fit inside the available space, rather than expand be clipped
Issues Fixed
Fixes #21683 #21970