Enforce CA1854 performance analyzer

[symbiogenesis]

This is hopefully a straightforward change. Similar to #22092

See: CA1854

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

Not compiling. Needs more changes in the ApplyPropertiesVisitor class.

D:\a\_work\1\s\src\Controls\src\Xaml\ApplyPropertiesVisitor.cs(362,61): error CS0165: Use of unassigned local variable 'value' [D:\a\_work\1\s\src\Controls\src\Xaml\Controls.Xaml.csproj::TargetFramework=net8.0-windows10.0.20348.0]
    21 Error(s)

[symbiogenesis]

Not compiling. Needs more changes in the ApplyPropertiesVisitor class.

Fixed.

[danmoseley]

Thanks!

[danmoseley]

@Eilon

[Eilon]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[Eilon]

Actually, looks like there are some legitimate failures in the build now that the analyzer is an error:

/Users/builder/azdo/_work/1/s/src/Core/src/Platform/Tizen/WindowExtensions.cs(24,8): error CA1854: Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854) [/Users/builder/azdo/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net8.0-tizen]
/Users/builder/azdo/_work/1/s/src/Core/src/Platform/Tizen/WindowExtensions.cs(65,8): error CA1854: Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854) [/Users/builder/azdo/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net8.0-tizen]
/Users/builder/azdo/_work/1/s/src/Core/src/Platform/Tizen/WindowExtensions.cs(106,8): error CA1854: Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854) [/Users/builder/azdo/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net8.0-tizen]
/Users/builder/azdo/_work/1/s/src/Core/src/Platform/Tizen/WindowExtensions.cs(112,8): error CA1854: Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854) [/Users/builder/azdo/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net8.0-tizen]
/Users/builder/azdo/_work/1/s/src/Core/src/Platform/Tizen/StackNavigationManager.cs(196,8): error CA1854: Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854) [/Users/builder/azdo/_work/1/s/src/Core/src/Core.csproj::TargetFramework=net8.0-tizen]

[symbiogenesis]

Looks like I should add the Tizen workload locally. Fixed those builds.

[Eilon]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[Eilon]

Some more errors 😢

D:\a\_work\1\s\src\Core\src\Platform\Tizen\StackNavigationManager.cs(205,8): error CS0128: A local variable or function named 'naviPage' is already defined in this scope [D:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net8.0-tizen]
D:\a\_work\1\s\src\Core\src\Platform\Tizen\StackNavigationManager.cs(211,21): error CS8601: Possible null reference assignment. [D:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net8.0-tizen]
D:\a\_work\1\s\src\Core\src\Platform\Tizen\StackNavigationManager.cs(213,11): error CS8603: Possible null reference return. [D:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net8.0-tizen]

[Eilon]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[symbiogenesis]

Rerun failed tests?

[Eilon]

Rerun failed tests?

Yup trying now.

[Eilon]

This test seems to be failing consistently:

Expected string length 21 but was 12. Strings differ at index 0.
Expected: "parameterless factory"
But was:  "default ctor"
-----------^

Stack trace
   at Microsoft.Maui.Controls.Xaml.UnitTests.FactoryMethods.Tests.TestArgumentlessFactoryMethod(Boolean useCompiledXaml) in /Users/builder/azdo/_work/3/s/src/Controls/tests/Xaml.UnitTests/FactoryMethods.xaml.cs:line 109
   at InvokeStub_Tests.TestArgumentlessFactoryMethod(Object, Span`1)

1)    at Microsoft.Maui.Controls.Xaml.UnitTests.FactoryMethods.Tests.TestArgumentlessFactoryMethod(Boolean useCompiledXaml) in /Users/builder/azdo/_work/3/s/src/Controls/tests/Xaml.UnitTests/FactoryMethods.xaml.cs:line 109
   at InvokeStub_Tests.TestArgumentlessFactoryMethod(Object, Span`1)

So maybe there's some problem in the change itself?

[Eilon]

Given that this PR does change code to do with finding factory methods, and that this particular test has failed multiple times in the PR, I think it warrants an investigation of the code in the PR. Maybe there's some subtle change in terms of how the code now locates matches for constructors somehow?

[PureWeen]

Closing based on @Eilon 's last comment