Skip to content

Enforce CA1853 performance analyzer #22092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 1 commit into from
Apr 27, 2024
Merged

Enforce CA1853 performance analyzer #22092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Controls/src/Core/Handlers/Items/Android/Adapters/ItemsViewAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,7 @@ public override int GetItemViewType(int position)
var id = template?.Id ?? ItemViewType.TemplatedItem;

// Cache the data template for future use
if (!_viewTypeDataTemplates.ContainsKey(id))
_viewTypeDataTemplates.Add(id, template);

_viewTypeDataTemplates.TryAdd(id, template);
return id;
}

Expand Down
1 change: 1 addition & 0 deletions src/Core/src/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ dotnet_diagnostic.CA1846.severity = error
dotnet_diagnostic.CA1847.severity = error
dotnet_diagnostic.CA1859.severity = error
dotnet_diagnostic.CA1860.severity = error
dotnet_diagnostic.CA1864.severity = error
dotnet_diagnostic.CA1865.severity = error
dotnet_diagnostic.CA2249.severity = error
3 changes: 1 addition & 2 deletions src/Core/src/VisualDiagnostics/VisualDiagnosticsOverlay.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@ public void AddScrollableElementHandler(IScrollView scrollBar)

if (nativeScroll != null && nativeScroll is ScrollViewer viewer)
{
if (!_scrollViews.ContainsKey(scrollBar))
if (_scrollViews.TryAdd(scrollBar, viewer))
{
_scrollViews.Add(scrollBar, viewer);
viewer.ViewChanging += OnViewChanging;
}
}
Expand Down