Remove excess check in iOS input transparency checks#21883
Merged
Conversation
mattleibow
approved these changes
Apr 26, 2024
mattleibow
requested changes
Apr 26, 2024
|
|
||
| App.WaitForElement("WaitForStubControl"); | ||
| App.ScrollDown("WaitForStubControl", ScrollStrategy.Gesture, 0.75); | ||
| App.Screenshot("Scrolling has been done correctly."); |
Member
There was a problem hiding this comment.
This should be a VerifyScreenshot maybe?
Member
Author
|
/rebase |
mattleibow
changed the title
PureWeen
force-pushed
the
remove_transparent_check
branch
from
09bce6c to
567a3a7
Compare
Member
Author
|
/rebase |
github-actions
Bot
force-pushed
the
remove_transparent_check
branch
from
567a3a7 to
30a7bb4
Compare
Member
Author
|
/rebase |
github-actions
Bot
force-pushed
the
remove_transparent_check
branch
from
30a7bb4 to
63c9b62
Compare
mattleibow
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix issue that does not allow scrolling in WebView with PDF on iOS.
Initially, I started by checking the status of the WebView: if internal UIScrollView scrolling was enabled, if the assigned size was correct, etc. Everything is fine so let's go check the hierarchy. It was interesting that the problem does not appear without a Layout as a parent. Reviewing I realized that the problem comes from the changes applied in #17286 related to InputTransparent. Applied changes to keep the InputTransparent working and fix the issue.
Issues Fixed
Fixes #18716