Allow PathFigureCollection to string conversion via converter#19889
Conversation
|
Hey there @symbiogenesis! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
f1a05d9 to
b572e88
Compare
|
/azp run |
This comment was marked as off-topic.
This comment was marked as off-topic.
b572e88 to
df6de3d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
df6de3d to
89d9e9b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Do you have an example? |
|
Hi @symbiogenesis. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time. |
89d9e9b to
682dbf2
Compare
I just updated the tests so that the complex tests can pass bi-directionally. It required making the InlineData conform to stricter standards. But those standards are just needed to create a fully identical string for bi-directional testing purposes. The standard itself is more forgiving, but the ToString operation needs to pick one of the multiple valid ways to serialize the path. |
|
Hi @symbiogenesis. |
|
This has unit tests and the pipeline seems good. Would be nice to get it merged. |
|
Is this PR possibly related to #20552 in any way? |
Seems likely. I mainly think native MAUI vector usage via Shapes should get more love. We should be able to directly translate SVG to real MAUI shapes, and back again, ideally. I have been able to write code to translate SVG into MAUI graphics to some degree. It feels kind of within reach. |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This should be fairly self-explanatory. Allows path figures to be serialized as a string, using the SVG path syntax, not just deserialized.
I added a full round-trip test in the simple test and the ComplexPaths test.