Ensure templates create a proper AppID#18322
Merged
Merged
Conversation
Eilon
reviewed
Oct 24, 2023
mattleibow
reviewed
Oct 24, 2023
Member
|
Can this be rebased on net8.0 so it can be part of GA? |
jknaudt21
force-pushed
the
dev/jd/templates2
branch
from
99b0691 to
2774155
Compare
Eilon
approved these changes
Oct 24, 2023
mattleibow
approved these changes
Oct 24, 2023
samhouts
added
the
fixed-in-8.0.100-rc.2.9530
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a template change that allowed new apps to specify the ApplicationID through the command line (#13509), if new apps created with spaces or non-alphanumeric characters in the name didn't specify an ApplicationID, they would be generated with an invalid ApplicationID.
Solution
Added an extra symbol created during template processing
nameToAppIdthat grabs the app's lowercased name and creates a valid AppID that:Example:
123 Cats.Fishy+)=>123_cats.fishy__Issues Fixed
Fixes #18177