[Templates] Fix template typo#18166
Merged
Merged
Conversation
jknaudt21
added
the
area-templates
Contributor
|
What branch should this go to? Presumably we need this for net8-rtm? |
mattleibow
approved these changes
Oct 23, 2023
mattleibow
previously requested changes
Oct 23, 2023
Member
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
main is only for SR1, if this is needed for GA, could you retarget to net8.0
jknaudt21
force-pushed
the
dev/jd/templatetypo
branch
from
50170ff to
8644004
Compare
Contributor
Author
Done! |
rmarinho
approved these changes
Oct 24, 2023
Contributor
Author
|
@Eilon could I get a review :) ? We need it since you're part of the dotnet-maui-blazor team |
jsuarezruiz
approved these changes
Oct 25, 2023
Eilon
approved these changes
Oct 25, 2023
samhouts
added
the
fixed-in-8.0.100-rc.2.9530
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
There was a typo in the template: RuntimeIdentifer vs RuntimeIdentifier. (Missing the last i)
This caused me some trouble debugging because I don't trust my own typing and copy pasted from the template - only to be left wondering why my RuntimeIdentifier was not being respected 😛