Add Pages VC View opposed to the handlers view#13510
Merged
mattleibow merged 7 commits intomainfrom Mar 29, 2023
Merged
Conversation
PureWeen
force-pushed
the
add_view_from_vc_not_handler
branch
from
ec30480 to
c018724
Compare
Contributor
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
force-pushed
the
add_view_from_vc_not_handler
branch
from
3fc3b75 to
f74ccc1
Compare
Contributor
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
Member
Author
|
/rebase |
PureWeen
force-pushed
the
add_view_from_vc_not_handler
branch
from
fa9378d to
f8a35e0
Compare
StephaneDelcroix
approved these changes
Mar 29, 2023
mattleibow
approved these changes
Mar 29, 2023
samhouts
added
area-controls-shell
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Go to next entry code wasn't working with shell because on iOS with shell we were never accessing ViewController.View on the PageViewController. This means that the View property on the PageViewController was never loading. We would just add the PageView.
This PR adds the View via the VC instead of the Handler so that the PageViewController can be setup as a NextResponder and thus be located by the FindNext code
The previous version of this PR didn't quite work. We also needed to change which view we are setting the
Frameon insideShellSectionRootRenderer.ShellSectionRootRendererneeds to set theFrameon the Page ViewControllers View instead of the PlatformView.Issues Fixed
Fixes #13332