Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Remove all uses of Styleable arrays inside the .NET MAUI code #4889

Closed
PureWeen opened this issue Feb 24, 2022 · 0 comments · Fixed by #4912
Closed

[Android] Remove all uses of Styleable arrays inside the .NET MAUI code #4889

PureWeen opened this issue Feb 24, 2022 · 0 comments · Fixed by #4912
Assignees
Labels
fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! legacy-area-perf Startup / Runtime performance platform/android 🤖 t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.)
Milestone

Comments

@PureWeen
Copy link
Member

PureWeen commented Feb 24, 2022

In order to enable some optimization features we need to remove uses of Styleable arrays from our code

https://github.com/dotnet/maui/blob/main/src/Controls/src/Core/Platform/Android/Resource.designer.cs#L154

if (_defaultTitleTextColor == null)
{
var a = TintTypedArray.ObtainStyledAttributes(nativeToolbar.Context?.GetThemedContext(), null, Resource.Styleable.Toolbar, Resource.Attribute.toolbarStyle, 0);
_defaultTitleTextColor = a.GetColorStateList(Resource.Styleable.Toolbar_titleTextColor);
a.Recycle();
}

@dellis1972

@PureWeen PureWeen added platform/android 🤖 legacy-area-perf Startup / Runtime performance labels Feb 24, 2022
@PureWeen PureWeen self-assigned this Feb 24, 2022
@PureWeen PureWeen added this to the 6.0.300-preview.14 milestone Feb 24, 2022
@Redth Redth modified the milestones: 6.0.300-preview.14, 6.0.300 Mar 21, 2022
@mattleibow mattleibow assigned mattleibow and unassigned PureWeen Apr 29, 2022
@mattleibow mattleibow modified the milestones: 6.0.300, 6.0.300-rc.3 Apr 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 1, 2022
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Feb 17, 2023
@Eilon Eilon added the t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! legacy-area-perf Startup / Runtime performance platform/android 🤖 t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants