Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "Razor component" and avoid "Blazor component" #4830

Closed
guardrex opened this issue Feb 22, 2022 · 4 comments
Closed

Use "Razor component" and avoid "Blazor component" #4830

guardrex opened this issue Feb 22, 2022 · 4 comments
Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! proposal/open

Comments

@guardrex
Copy link
Contributor

guardrex commented Feb 22, 2022

Description

I'm going to move this over from a GH discussion because I'm having good luck 🍀 thus far getting MS pubs updated on the point, and I hope we'll be able to address the lingering instances of "Blazor component" in frameworks. Separately, I've opened this for the ASP.NET Core team (dotnet/aspnetcore) at dotnet/aspnetcore#40344, and they've agreed to my sending a PR to update it there.

Mirroring the discussion remarks that I posted at #4799 ...

The term "Blazor component" is valid informal naming for Razor components, which is the official, formal name. See my remarks here ...

dotnet/docs-maui#295

I recommend that in the few spots in framework code where the term "Blazor component" appears that it be changed to either "Razor component" or just "component" to resolve the dual-naming problem and completely align the framework code/API docs with the Blazor docs.

Public API Changes

"Blazor component" only appears in three files here, usually in comments that will resolve to API docs ...

If you'd entertain a PR from me to update these spots, I'll create a PR to knock it out 🥊. Let me know 📣👂.

Intended Use-Case

"Blazor component" has slipped out a little bit into the community, but I think we can head off further wide adoption by stomping it out NOW 🏃 ... quickly 🏃🏃. Future generations will thank us! 😄

@guardrex guardrex changed the title Use "Razor component" and avoid "Blazor component" in the MAUI framework Use "Razor component" and avoid "Blazor component" Feb 22, 2022
@Eilon
Copy link
Member

Eilon commented Feb 22, 2022

@guardrex I think a PR would be great if you have time!

@Eilon Eilon added the area-blazor Blazor Hybrid / Desktop, BlazorWebView label Feb 22, 2022
@mkArtakMSFT
Copy link
Member

Thanks @guardrex . Should this be closed now ?

@guardrex
Copy link
Contributor Author

guardrex commented Feb 24, 2022

btw ... Your guidance for PR submissions says not to use "fixes" but to use "implements" instead. Not sure if that guidance was by-design or not. Just letting you know why this stayed open.

https://github.com/dotnet/maui/blame/main/.github/PULL_REQUEST_TEMPLATE.md#L21

@Eilon
Copy link
Member

Eilon commented Feb 24, 2022

@guardrex oh that's a bit weird. I'll contact some other MAUI folks to see if that was deliberate.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
@samhouts samhouts added the fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! label Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! proposal/open
Projects
None yet
Development

No branches or pull requests

4 participants