Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression/8.0.0-rc.1.9171] SwipeView Execute mode does not work when using Binding Command #17371

Closed
tranb3r opened this issue Sep 14, 2023 · 2 comments · Fixed by #17418
Closed

[regression/8.0.0-rc.1.9171] SwipeView Execute mode does not work when using Binding Command #17371

tranb3r opened this issue Sep 14, 2023 · 2 comments · Fixed by #17418
Assignees
@PureWeen
Labels
area-controls-swipeview SwipeView fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! i/regression This issue described a confirmed regression on a currently supported version platform/android 🤖 t/bug Something isn't working
Milestone
.NET 8 GA

Comments

@tranb3r
Copy link

tranb3r commented Sep 14, 2023 •
edited by samhouts
Loading

Description

In net8-rc1, on android, Execute mode of a SwipeView is not working when using Binding Command.
This was working in net7 and also in net8-pre2.

Steps to Reproduce

  1. Open repro project
  2. Swipe left
  3. The GO action should be invoked
  4. The binded command should do a Console.WriteLine, check your output.
  5. Unfortunately, on net8-rc1, the command is not executed.

Link to public reproduction project repository

https://github.com/tranb3r/Issues/tree/main/MauiAppTestSwipeView

Version with bug

8.0.0-rc.1.9171

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

8.0.0-preview.7.8842

Affected platforms

Android

Affected platform versions

Android 34

Did you find any workaround?

When using SwipeItem.Invoked instead of the Binding Command, it seems to work.
But it's not really a workaround.

Relevant log output

No response
@tranb3r tranb3r added the t/bug Something isn't working label Sep 14, 2023
@tranb3r
Copy link
Author

tranb3r commented Sep 14, 2023

Could be related to #16345

@samhouts samhouts added area-controls-swipeview SwipeView i/regression This issue described a confirmed regression on a currently supported version labels Sep 14, 2023
@samhouts samhouts added this to the .NET 8 GA milestone Sep 14, 2023
@samhouts
Copy link
Member

samhouts commented Sep 14, 2023 •
edited
Loading

Yep, regressed between 8.0.0-preview.7.8842 and 8.0.0-rc.1.9171, so I think #16753 is the culprit. Thanks!

@samhouts samhouts changed the title [net8-rc1] SwipeView Execute mode does not work when using Binding Command [regression/8.0.0-rc.1.9171] SwipeView Execute mode does not work when using Binding Command Sep 14, 2023
This was referenced Sep 15, 2023
Closed
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in MAUI SDK Ongoing Sep 21, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! label Oct 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@PureWeen PureWeen

Labels
area-controls-swipeview SwipeView fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! i/regression This issue described a confirmed regression on a currently supported version platform/android 🤖 t/bug Something isn't working
Projects
None yet
Milestone
.NET 8 GA
Development

Successfully merging a pull request may close this issue.

Cleanup SwipeView and Propagate BC until we can fix compat layout dotnet/maui
3 participants
@PureWeen @samhouts @tranb3r