Fix for [Windows] HorizontalScrollBarVisibility="Never" not working in CarouselView on Windows platform (#29343)

* Update ItemsViewHandler.Windows.cs

* Update ItemsViewHandler.Windows.cs

* Commit for ScrollBarVisibility

* Testcase included

* Update Issue15253.cs

* Tes

* testcases enabled

* Update Issue15253.cs

* Image updated

* method change

Author: SuthiYuvaraj

src/Controls/src/Core/Handlers/Items/CarouselViewHandler.Windows.cs

@@ -98,7 +98,14 @@ protected override void OnScrollViewerFound(ScrollViewer scrollViewer)
 			_scrollViewer.ViewChanged += OnScrollViewChanged;
 			_scrollViewer.SizeChanged += OnScrollViewSizeChanged;
 
-			UpdateScrollBarVisibilityForLoop();
+			if (Element.Loop)
+			{
+				UpdateScrollBarVisibilityForLoop();
+			}
+			else
+			{
+				UpdateScrollBarVisibility();
+			}
 		}
 
 		protected override ICollectionView GetCollectionView(CollectionViewSource collectionViewSource)

src/Controls/src/Core/Handlers/Items/ItemsViewHandler.Windows.cs

@@ -351,8 +351,7 @@ protected virtual void UpdateItemsLayout()
 
 			UpdateItemTemplate();
 			UpdateItemsSource();
-			UpdateVerticalScrollBarVisibility();
-			UpdateHorizontalScrollBarVisibility();
+			UpdateScrollBarVisibility();
 			UpdateEmptyView();
 		}
 
@@ -376,6 +375,12 @@ void ListViewLoaded(object sender, RoutedEventArgs e)
 			listView.Loaded += ListViewLoaded;
 		}
 
+		internal void UpdateScrollBarVisibility()
+		{
+			UpdateVerticalScrollBarVisibility();
+			UpdateHorizontalScrollBarVisibility();
+		}
+
 		void UpdateVerticalScrollBarVisibility()
 		{
 			if (Element.VerticalScrollBarVisibility != ScrollBarVisibility.Default)

src/Controls/tests/TestCases.Android.Tests/snapshots/android/HorizontalScrollBarShouldHideOnNever.png

@@ -0,0 +1,83 @@
+using System.Collections.ObjectModel;
+
+namespace Maui.Controls.Sample.Issues;
+
+[Issue(IssueTracker.Github, 15253, "[Windows]HorizontalScrollBarVisibility doesnot works", PlatformAffected.UWP)]
+
+public class Issue15253 : ContentPage
+{
+	ObservableCollection<Model15253> Items;
+	public Issue15253()
+	{
+		Items = new ObservableCollection<Model15253>();
+		Items.Add(new Model15253 { Name = "one", AutomationId = "15253One" });
+		Items.Add(new Model15253 { Name = "two", AutomationId = "15253Two" });
+		Items.Add(new Model15253 { Name = "three", AutomationId = "15253Three" });
+		var carouselView = new CarouselView
+		{
+			WidthRequest = 200,
+			HeightRequest = 200,
+			AutomationId = "15253CarouselView",
+			Loop = false,
+			VerticalScrollBarVisibility = ScrollBarVisibility.Never,
+			HorizontalScrollBarVisibility = ScrollBarVisibility.Never,
+			BackgroundColor = Colors.LightBlue,
+			ItemsSource = Items,
+			ItemTemplate = new DataTemplate(() =>
+			{
+				var label = new Label
+				{
+					FontSize = 32,
+					TextColor = Colors.Black,
+					HorizontalTextAlignment = TextAlignment.Center,
+					BackgroundColor = Colors.LightBlue
+
+				};
+				label.SetBinding(Label.TextProperty, "Name");
+				label.SetBinding(Label.AutomationIdProperty, "AutomationId");
+
+				var stack = new StackLayout
+				{
+					Orientation = StackOrientation.Vertical,
+					VerticalOptions = LayoutOptions.Center,
+					HorizontalOptions = LayoutOptions.Center,
+					WidthRequest = 200,
+					Children = { label }
+				};
+				return new ContentView { Content = stack };
+			})
+		};
+
+
+		var toggleButton = new Button
+		{
+			Text = "Toggle Scrollbar",
+			AutomationId = "15253Button"
+		};
+
+		toggleButton.Clicked += (s, e) =>
+		{
+			carouselView.HorizontalScrollBarVisibility = carouselView.HorizontalScrollBarVisibility == ScrollBarVisibility.Never
+				? ScrollBarVisibility.Always
+				: ScrollBarVisibility.Never;
+		};
+
+		var outerStack = new StackLayout
+		{
+			Orientation = StackOrientation.Vertical,
+			VerticalOptions = LayoutOptions.Center,
+			HorizontalOptions = LayoutOptions.Center,
+			Spacing = 8,
+			Padding = 8,
+			Children = { toggleButton, carouselView }
+		};
+
+		Content = outerStack;
+	}
+
+}
+public class Model15253
+{
+	public string Name { get; set; }
+	public string AutomationId { get; set; }
+}

src/Controls/tests/TestCases.HostApp/Issues/Issue15253.cs

@@ -8,9 +8,7 @@ public partial class Issue28098 : ContentPage
 	public Issue28098()
 	{
 		InitializeComponent();
-		#if ANDROID
 		carouselView.HorizontalScrollBarVisibility = ScrollBarVisibility.Never;
-		#endif
 	}
 
 	protected override void OnAppearing()

src/Controls/tests/TestCases.HostApp/Issues/Issue28098.xaml.cs

@@ -0,0 +1,24 @@
+using NUnit.Framework;
+using UITest.Core;
+using UITest.Appium;
+
+namespace Microsoft.Maui.TestCases.Tests.Issues
+{
+	internal class Issue15253 : _IssuesUITest
+	{
+		public override string Issue => "[Windows]HorizontalScrollBarVisibility doesnot works";
+		public Issue15253(TestDevice device) : base(device)
+		{
+		}
+
+		[Test]
+		[Category(UITestCategories.CarouselView)]
+		public void HorizontalScrollBarShouldHideOnNever()
+		{
+			// Is a Windows issue; see https://github.com/dotnet/maui/issues/15253
+			App.WaitForElement("15253CarouselView");
+			App.Tap("one");
+			VerifyScreenshot();
+		}
+	}
+}

src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/BlankScreenOnNavigationBack.png

@@ -18,10 +18,6 @@ public void BlankScreenOnNavigationBack()
         App.Tap("Button");
         App.WaitForElement("BackButton");
         App.Tap("BackButton");
-#if WINDOWS
-        VerifyScreenshot(cropBottom: 250);
-#else
         VerifyScreenshot();
-#endif
     }
 }