Applying visibility change to child controls (#19139)

Author: kubaflo

src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt

@@ -236,3 +236,4 @@ Microsoft.Maui.Controls.ContentPage.HideSoftInputOnTapped.set -> void
 *REMOVED*Microsoft.Maui.Controls.Entry.FontSize.set -> void
 *REMOVED*Microsoft.Maui.Controls.Entry.SelectionLength.get -> int
 *REMOVED*Microsoft.Maui.Controls.Entry.SelectionLength.set -> void
+Microsoft.Maui.Controls.VisualElement.RefreshIsVisibleProperty() -> void

src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt

@@ -72,6 +72,7 @@ Microsoft.Maui.Controls.PointerGestureRecognizer.PointerReleasedCommand.get -> S
 Microsoft.Maui.Controls.PointerGestureRecognizer.PointerReleasedCommand.set -> void
 Microsoft.Maui.Controls.PointerGestureRecognizer.PointerReleasedCommandParameter.get -> object!
 Microsoft.Maui.Controls.PointerGestureRecognizer.PointerReleasedCommandParameter.set -> void
+Microsoft.Maui.Controls.VisualElement.RefreshIsVisibleProperty() -> void
 static readonly Microsoft.Maui.Controls.KeyboardAccelerator.KeyProperty -> Microsoft.Maui.Controls.BindableProperty!
 static readonly Microsoft.Maui.Controls.KeyboardAccelerator.ModifiersProperty -> Microsoft.Maui.Controls.BindableProperty!
 static readonly Microsoft.Maui.Controls.DragGestureRecognizer.CanDragProperty -> Microsoft.Maui.Controls.BindableProperty!

src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt

@@ -252,4 +252,5 @@ Microsoft.Maui.Controls.ContentPage.HideSoftInputOnTapped.set -> void
 *REMOVED*Microsoft.Maui.Controls.Entry.FontSize.set -> void
 *REMOVED*Microsoft.Maui.Controls.Entry.SelectionLength.get -> int
 *REMOVED*Microsoft.Maui.Controls.Entry.SelectionLength.set -> void
+Microsoft.Maui.Controls.VisualElement.RefreshIsVisibleProperty() -> void
 

src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt

@@ -213,3 +213,4 @@ Microsoft.Maui.Controls.ContentPage.HideSoftInputOnTapped.set -> void
 *REMOVED*Microsoft.Maui.Controls.Entry.FontSize.set -> void
 *REMOVED*Microsoft.Maui.Controls.Entry.SelectionLength.get -> int
 *REMOVED*Microsoft.Maui.Controls.Entry.SelectionLength.set -> void
+Microsoft.Maui.Controls.VisualElement.RefreshIsVisibleProperty() -> void

src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt

@@ -245,3 +245,4 @@ Microsoft.Maui.Controls.ContentPage.HideSoftInputOnTapped.set -> void
 *REMOVED*Microsoft.Maui.Controls.Entry.FontSize.set -> void
 *REMOVED*Microsoft.Maui.Controls.Entry.SelectionLength.get -> int
 *REMOVED*Microsoft.Maui.Controls.Entry.SelectionLength.set -> void
+Microsoft.Maui.Controls.VisualElement.RefreshIsVisibleProperty() -> void

src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt

@@ -207,3 +207,4 @@ Microsoft.Maui.Controls.PlatformPointerEventArgs
 *REMOVED*Microsoft.Maui.Controls.Entry.FontSize.set -> void
 *REMOVED*Microsoft.Maui.Controls.Entry.SelectionLength.get -> int
 *REMOVED*Microsoft.Maui.Controls.Entry.SelectionLength.set -> void
+Microsoft.Maui.Controls.VisualElement.RefreshIsVisibleProperty() -> void

src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt

@@ -210,4 +210,4 @@ Microsoft.Maui.Controls.ContentPage.HideSoftInputOnTapped.set -> void
 *REMOVED*Microsoft.Maui.Controls.Entry.FontSize.set -> void
 *REMOVED*Microsoft.Maui.Controls.Entry.SelectionLength.get -> int
 *REMOVED*Microsoft.Maui.Controls.Entry.SelectionLength.set -> void
-
+Microsoft.Maui.Controls.VisualElement.RefreshIsVisibleProperty() -> void

src/Controls/src/Core/VisualElement/VisualElement.cs

@@ -265,9 +265,12 @@ static void OnTransformChanged(BindableObject bindable, object oldValue, object
 			BindableProperty.Create("TransformOrigin", typeof(Point), typeof(VisualElement), new Point(.5d, .5d),
 									propertyChanged: (b, o, n) => { (((VisualElement)b).AnchorX, ((VisualElement)b).AnchorY) = (Point)n; });
 
+		bool _isVisibleExplicit = (bool)IsVisibleProperty.DefaultValue;
+
 		/// <summary>Bindable property for <see cref="IsVisible"/>.</summary>
 		public static readonly BindableProperty IsVisibleProperty = BindableProperty.Create("IsVisible", typeof(bool), typeof(VisualElement), true,
-			propertyChanged: (bindable, oldvalue, newvalue) => ((VisualElement)bindable).OnIsVisibleChanged((bool)oldvalue, (bool)newvalue));
+			propertyChanged: (bindable, oldvalue, newvalue) => ((VisualElement)bindable).OnIsVisibleChanged((bool)oldvalue, (bool)newvalue),
+			coerceValue: CoerceIsVisibleProperty);
 
 		/// <summary>Bindable property for <see cref="Opacity"/>.</summary>
 		public static readonly BindableProperty OpacityProperty = BindableProperty.Create("Opacity", typeof(double), typeof(VisualElement), 1d, coerceValue: (bindable, value) => ((double)value).Clamp(0, 1));
@@ -679,6 +682,36 @@ private protected bool InputTransparentCore
 			}
 		}
 
+		/// <summary>
+		/// This value represents the cumulative IsVisible value.
+		/// All types that override this property need to also invoke
+		/// the RefreshIsVisibleProperty() method if the value will change.
+		/// </summary>
+		private protected bool IsVisibleCore
+		{
+			get
+			{
+				if (_isVisibleExplicit == false)
+				{
+					// If the explicitly set value is false, then nothing else matters
+					// And we can save the effort of a Parent check
+					return false;
+				}
+
+				var parent = Parent as VisualElement;
+				while (parent is not null)
+				{
+					if (!parent.IsVisible)
+					{
+						return false;
+					}
+					parent = parent.Parent as VisualElement;
+				}
+
+				return _isVisibleExplicit;
+			}
+		}
+
 		/// <summary>
 		/// Gets a value indicating whether this element is focused currently. This is a bindable property.
 		/// </summary>
@@ -1426,6 +1459,7 @@ internal virtual void OnIsVisibleChanged(bool oldValue, bool newValue)
 				fe.Handler?.UpdateValue(nameof(IView.Visibility));
 			}
 
+			(this as IPropertyPropagationController)?.PropagatePropertyChanged(IsVisibleProperty.PropertyName);
 			InvalidateMeasureInternal(InvalidationTrigger.Undefined);
 		}
 
@@ -1590,6 +1624,17 @@ static object CoerceInputTransparentProperty(BindableObject bindable, object val
 			return false;
 		}
 
+		static object CoerceIsVisibleProperty(BindableObject bindable, object value)
+		{
+			if (bindable is VisualElement visualElement)
+			{
+				visualElement._isVisibleExplicit = (bool)value;
+				return visualElement.IsVisibleCore;
+			}
+
+			return false;
+		}
+
 		static void OnInputTransparentPropertyChanged(BindableObject bindable, object oldValue, object newValue)
 		{
 			(bindable as IPropertyPropagationController)?.PropagatePropertyChanged(VisualElement.InputTransparentProperty.PropertyName);
@@ -1657,6 +1702,9 @@ void IPropertyPropagationController.PropagatePropertyChanged(string propertyName
 			if (propertyName == null || propertyName == InputTransparentProperty.PropertyName)
 				this.RefreshPropertyValue(InputTransparentProperty, _inputTransparentExplicit);
 
+			if (propertyName == null || propertyName == IsVisibleProperty.PropertyName)
+				this.RefreshPropertyValue(IsVisibleProperty, _isVisibleExplicit);
+
 			PropertyPropagationExtensions.PropagatePropertyChanged(propertyName, this, ((IVisualTreeElement)this).GetVisualChildren());
 		}
 
@@ -1667,6 +1715,13 @@ void IPropertyPropagationController.PropagatePropertyChanged(string propertyName
 		protected void RefreshIsEnabledProperty() =>
 			this.RefreshPropertyValue(IsEnabledProperty, _isEnabledExplicit);
 
+		/// <summary>
+		/// This method must always be called if some event occurs and the value of
+		/// the <see cref="IsVisibleCore"/> property will change.
+		/// </summary>
+		protected void RefreshIsVisibleProperty() =>
+			this.RefreshPropertyValue(IsVisibleProperty, _isVisibleExplicit);
+
 		/// <summary>
 		/// This method must always be called if some event occurs and the value of
 		/// the InputTransparentCore property will change.