Migrate System.ValueTuple #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…references to pkgproj
This adds validation for Xamarin frameworks and fixes some packages which were not representing Xamarin correctly.
…72159 Updating CoreFx dependencies to beta-24312-04
Allow TupleElementNamesAttribute on events
This package is a support package for NETStandard2.0 on .NET 4.6.1.
* Skip test on netfx * Fix build * build2 * build3
Merging on behalf of @azhmur Thanks!
This is necessary to avoid type conflicts.
Fix mistake in summary.
…ssertExtensions (#21455) * Registry * Collections * ComponentModel * Configuration * Data * Globalization * Drawing * Diagnostics * IO * Linq * Add System.Net param names in tests * Move ArgumentExceptions in System.Private.Xml to AssertExtensions * Add System.Reflection.* ArgumentException param names * Add param names for System.Runtime* ArgumentExceptions * Add ArgumentException param names to System.Security.* * Add ArgumentException param names to System.Text.* * Add param names to ArgumentExceptions in misc projects * Add System.Threading.* ArgumentException param names * Fix missing files * Fixes for unix and netfx * Fix more failures and revert a IdnaConformance tests to avoid merge conflicts with #21463
* Move AssertExtensions to Corefx.Private.TestUtilities * Update csprojs * Fix Linq.Expressions uapaot build
Renaming uap10.1 to uap10.0.15138
…3109) * Moving PlatformDetection to Corefx.Private.TestUtilities assembly The purpose of this change is to clean up all test projects instead of including the PlatformDetection code inside every test project, we’ll have it in the Corefx.Private.TestUtilities. I have refactored the PlatformDetection to split the different implementation of Windows and Linux. If we need to do more refactoring there we can do it later as needed. * Fix Linux BB * Update the xunit package reference * Fix wrong condition on one of the tests * Update the ConditionalFact/Theory to use Type as a parameter
Now that we've shipped the NETStandard support package we will no longer build its content from `master`. It will be serviced from the `release/2.0.0` branch and the only netfx builds in `master` will correspond to package content.
Many library packages overlap with assemblies we include in our framework packages. In the first release we handled this by preventing the library package from applying any assets. This becomes problematic if the reference assembly needs to version, and especially if the library wants to add API. The new version will be greater than what was previously shipped inbox, and we wouldn't want to restrict the new version just to future TFMs. To address this problem I've made a couple fixes: 1. For packages which are shipping brand new API that's not present in desktop, we'll omit any placeholders and allow conflict resolution to decide if the library package or framework package should be used (based on version). In some cases this required bringing some configurations into the package so that it could always be "up to date". 2. For packages which are just exposing API in desktop, and thus already tied/anchored to netstandard versions, we'll freeze the reference assembly version for the non-desktop builds. This ensures that the reference assembly will never move past the version that's inbox in the framework package. Update BuildToolsVersion to 2.0.0-prerelease-01931-01
…eVSConfigurations (#24752) * Fixed odbc configurations for compat package * Run UpdateVSConfigurations * Remove Default Configurations to help VS... comment from csproj's * Remove from System.Buffers as well
* Updating the package index for UAP and updating buildtools * Having System.Reflection.DispatchProxy crosscompile for uap RS3 * Updating buildtools and fixing PR feedback * Re-add support for uap to the assemblies that already had a netcoreapp2.0 config for Windows
|
I'm not sure what you want me to review. Do you just need an approval? If I understand correctly, most of the files are going to be deleted with a subsequent PR as those aren't necessary anymore (i.e. pkgproj, sln file, Configurations.props, etc). Just curious, why don't you include the repo infrastructure integration changes as part of this PR? |
|
We did that with SqlClient. First we only merged the commits, then the next PR was much easier to review, as it would not include hundreds of new commits and files. Also, if I need to merge main into my working branch, it's not going to make a mess of my commits when I need to squash my new changes at the end. Can you please approve? No need to review the content. |
ViktorHofer
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge commit.
No additional code changes, only migration. Will fix the infra after merge-commiting this.
Contributes to #183