Fixed up dimensions to create known sized vectors#4867
Merged
harishsk merged 1 commit intodotnet:masterfrom Feb 21, 2020
harishsk:onnxDimensionFix
Merged
Fixed up dimensions to create known sized vectors#4867harishsk merged 1 commit intodotnet:masterfrom harishsk:onnxDimensionFix
harishsk merged 1 commit intodotnet:masterfrom
harishsk:onnxDimensionFix
Conversation
antoniovs1029
approved these changes
Feb 21, 2020
ganik
approved these changes
Feb 21, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent PR (#4783) added support to run inferencing on an onnx model with multiple rows at a time. This made the output schema of OnnxTransformer to have variable size vectors which in turn broke some things in Nimbus. This PR fixes the dimensions back.