Skip to content

Comments

fixes #3992#4010

Closed
wangyems wants to merge 1 commit intodotnet:masterfrom
wangyems:task_1
Closed

fixes #3992#4010
wangyems wants to merge 1 commit intodotnet:masterfrom
wangyems:task_1

Conversation

@wangyems
Copy link
Contributor

fixes #3992, when inputColumnNames is not provided, it is set to new[] { outputColumnName }

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@wangyems wangyems requested a review from artidoro July 19, 2019 18:08
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangyems - can you add a test for this?

@yaeldekel
Copy link

Addressed by #4211 .

@yaeldekel yaeldekel closed this Sep 19, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FeaturizeText should allow only outputColumnName to be defined

3 participants