fixes from pr comments

Author: michaelgsharp

test/Microsoft.ML.Core.Tests/UnitTests/TestResourceDownload.cs

@@ -14,8 +14,6 @@
 using Xunit;
 using Xunit.Abstractions;
 
-//[assembly: CollectionBehavior(DisableTestParallelization = true)]
-
 namespace Microsoft.ML.Core.Tests.UnitTests
 {
     public class TestResourceDownload : BaseTestBaseline

test/Microsoft.ML.Tests/DatabaseLoaderTests.cs

@@ -227,54 +227,41 @@ public void IrisSdcaMaximumEntropy()
         [X86X64FactAttribute("The SQLite un-managed code, SQLite.interop, only supports x86/x64 architectures.")]
         public void TestLoadDatetimeColumnWithNullValue()
         {
-            try
+            var connectionString = "DataSource=Dummy;Mode=Memory;Version=3;Timeout=120;Cache=Shared";
+            using (var connection = new SQLiteConnection(connectionString))
             {
-                var connectionString = "DataSource=Dummy;Mode=Memory;Version=3;Timeout=120;Cache=Shared";
-                using (var connection = new SQLiteConnection(connectionString))
+                connection.Open();
+                using (var command = new SQLiteCommand(connection))
                 {
-                    connection.Open();
-                    using (var command = new SQLiteCommand(connection))
-                    {
-                        command.CommandText = """
+                    // Make sure the table doesn't exist.
+                    command.CommandText = """
                         BEGIN;
-                        CREATE TABLE IF NOT EXISTS Datetime (datetime Datetime NULL);
-                        INSERT INTO Datetime VALUES (NULL);
-                        INSERT INTO Datetime VALUES ('2018-01-01 00:00:00');
+                        DROP TABLE IF EXISTS Datetime;
                         COMMIT;
                         """;
-                        command.ExecuteNonQuery();
-                    }
-                }
-                var mlContext = new MLContext(seed: 1);
-                var loader = mlContext.Data.CreateDatabaseLoader(new DatabaseLoader.Column("datetime", DbType.DateTime, 0));
-                var source = new DatabaseSource(SQLiteFactory.Instance, connectionString, "SELECT datetime FROM Datetime");
-                var data = loader.Load(source);
-                var datetimes = data.GetColumn<DateTime>("datetime").ToArray();
-                datetimes.Count().Should().Be(2);
-
-                // Convert null value to DateTime.MinValue, aka 0001-01-01 00:00:00
-                // This is the default behavior of TextLoader as well.
-                datetimes[0].Should().Be(DateTime.MinValue);
-                datetimes[1].Should().Be(new DateTime(2018, 1, 1, 0, 0, 0));
-            }
-            finally
-            {
-                //Clean up in memory db if anything happens
-                var connectionString = "DataSource=Dummy;Mode=Memory;Version=3;Timeout=120;Cache=Shared";
-                using (var connection = new SQLiteConnection(connectionString))
-                {
-                    connection.Open();
-                    using (var command = new SQLiteCommand(connection))
-                    {
-                        command.CommandText = """
+                    command.ExecuteNonQuery();
+
+                    command.CommandText = """
                         BEGIN;
-                        DROP TABLE IF EXISTS Datetime;
+                        CREATE TABLE IF NOT EXISTS Datetime (datetime Datetime NULL);
+                        INSERT INTO Datetime VALUES (NULL);
+                        INSERT INTO Datetime VALUES ('2018-01-01 00:00:00');
                         COMMIT;
                         """;
-                        command.ExecuteNonQuery();
-                    }
+                    command.ExecuteNonQuery();
                 }
             }
+            var mlContext = new MLContext(seed: 1);
+            var loader = mlContext.Data.CreateDatabaseLoader(new DatabaseLoader.Column("datetime", DbType.DateTime, 0));
+            var source = new DatabaseSource(SQLiteFactory.Instance, connectionString, "SELECT datetime FROM Datetime");
+            var data = loader.Load(source);
+            var datetimes = data.GetColumn<DateTime>("datetime").ToArray();
+            datetimes.Count().Should().Be(2);
+
+            // Convert null value to DateTime.MinValue, aka 0001-01-01 00:00:00
+            // This is the default behavior of TextLoader as well.
+            datetimes[0].Should().Be(DateTime.MinValue);
+            datetimes[1].Should().Be(new DateTime(2018, 1, 1, 0, 0, 0));
         }
 
         /// <summary>

test/Microsoft.ML.TorchSharp.Tests/Microsoft.ML.TorchSharp.Tests.csproj

@@ -4,8 +4,6 @@
     <StrongNameKeyId>Test</StrongNameKeyId>
     <NoWarn>$(NoWarn)</NoWarn>
 
-    <!-- Remove once we have resolved the TorchSharp issue. -->
-    <ResolveAssemblyWarnOrErrorOnTargetArchitectureMismatch>None</ResolveAssemblyWarnOrErrorOnTargetArchitectureMismatch>
   </PropertyGroup>
 
   <!-- Import the test signing certificate -->